-
Notifications
You must be signed in to change notification settings - Fork 941
fix(deps): update errorproneversion to v2.47.0 #8051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y-java into renovate/errorproneversion
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8051 +/- ##
=========================================
Coverage 90.18% 90.18%
Complexity 7591 7591
=========================================
Files 841 841
Lines 22911 22911
Branches 2288 2288
=========================================
Hits 20663 20663
Misses 1531 1531
Partials 717 717 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| public static class TestCases { | ||
| private final PercentEscaper percentEscaper = new PercentEscaper(); | ||
|
|
||
| @SuppressWarnings("JdkObsolete") // Recommended alternative was introduced in java 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oddly, errorprone makes the mistake of flagging URLDecoder.decode(String, String) as obsolete recommending using URLDecoder.decode(String, Charset) only available in java 10. Seems like being language-version-aware would have to be a key consideration of this type of obsolete API detection.
Maybe its just a mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we hit this in contrib too: open-telemetry/opentelemetry-java-contrib#2617
This PR contains the following updates:
2.46.0→2.47.02.46.0→2.47.02.46.0→2.47.0Release Notes
google/error-prone (com.google.errorprone:error_prone_test_helpers)
v2.47.0: Error Prone 2.47.0New checks:
InterruptedInCatchBlock: Detect accidental calls toThread.interrupted()inside ofcatch(InterruptedException e)blocks.RefactorSwitch: Refactorings to simplify arrow switchesUnnamedVariable: Rename unused variables to_Closed issues: #1811, #4168, #5459, #5460
Full changelog: google/error-prone@v2.46.0...v2.47.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.