Replace Xlint deprecation check with custom errorprone check #8061
+434
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Feb 8, 2026
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| @SuppressWarnings({"unchecked", "deprecation"}) // deprecation: EXTENDED_ATTRIBUTES |
Member
Author
There was a problem hiding this comment.
it's slightly more strict than javac here, but this does align with Intellij's warnings, so seems good
trask
force-pushed
the
deprecate-with-errorprone
branch
5 times, most recently
from
e79ae1d to
cfd48d7
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (27.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8061 +/- ##
============================================
+ Coverage 90.18% 90.22% +0.03%
- Complexity 7591 7592 +1
============================================
Files 841 841
Lines 22911 22903 -8
Branches 2288 2288
============================================
+ Hits 20663 20664 +1
+ Misses 1531 1523 -8
+ Partials 717 716 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
force-pushed
the
deprecate-with-errorprone
branch
from
cfd48d7 to
6ebdc89
Compare
Member
|
This requirement to avoid importing deprecating classes has annoyed me for a while. I'm supportive if you can get the build to pass on java 21, 25 😛 |
trask
force-pushed
the
deprecate-with-errorprone
branch
from
6ebdc89 to
86e4227
Compare
trask
force-pushed
the
deprecate-with-errorprone
branch
from
86e4227 to
afc0f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #8060 (well, that and the many PRs in the instrumentation repo where this has plagued me recently)
Context:
When compiling with
--release 8, javac's-Xlint:deprecationwarns on imports of deprecated classes (JDK-8032211). Since@SuppressWarningscannot suppress import-level warnings, this forced us to use fully-qualified class names as a workaround.