Add setEnabledProtocols option to OTLP exporter builders#8610
Add setEnabledProtocols option to OTLP exporter builders#8610jack-berg wants to merge 3 commits into
Conversation
|
| ssl.trustManager(clientCertificate.certificate()); | ||
| // Restrict server to TLS 1.2+ so enabledProtocols tests are meaningful | ||
| // regardless of SSL backend (JDK TLS or BoringSSL via netty-tcnative). | ||
| ssl.protocols("TLSv1.2", "TLSv1.3"); |
There was a problem hiding this comment.
I was happy to see a nearly identical API from armeria
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8610 +/- ##
=========================================
Coverage 91.64% 91.64%
- Complexity 10348 10372 +24
=========================================
Files 1013 1013
Lines 27380 27441 +61
Branches 3218 3230 +12
=========================================
+ Hits 25092 25149 +57
- Misses 1558 1559 +1
- Partials 730 733 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull request dashboard statusStatus last refreshed: 2026-07-26 01:45:35 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
|
Hey @jack-berg, thanks for the detailed analysis. I had one question about test coverage: is there a test that verifies the actual motivating scenario from #7573 — successfully reaching a real TLSv1/TLSv1.1-only server with enabledProtocols set and the JVM floor opened? As written, I ran into a related issue testing this in my PR: I just wanted to confirm whether that was the reasoning, or if I missed an existing test covering it. |
|
Hi @adhamahmad - You make a good point. I updated the abstract http / grpc test classes to verify that when you restrict protocols to TLSv1.1, export fails. This ensures that the senders are indeed restricting based on protocols. But it doesn't demonstrate the actual motivating scenario from the issue. After reading your comment, I did try to update the abstract tests to recreate that situation but it proved impractical to configure the armeria test server used in those to downgrade to TLS 1.1, such that you could configure a client to use TLS 1.1 and get a successful export. I ended up added a dedicated simpler scoped test to OkHttpHttpSenderTest in 9394db0 which recreates a server accepting only TLS 1.1 at a lower level. It looks somewhat similar to the test in your PR. |
…y-java into otlp-enabled-protocols
Fixes #7573