-
Notifications
You must be signed in to change notification settings - Fork 778
Allow loading all resource detectors by setting OTEL_EXPERIMENTAL_RESOURCE_DETECTORS to *
#4819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow loading all resource detectors by setting OTEL_EXPERIMENTAL_RESOURCE_DETECTORS to *
#4819
Conversation
…SOURCE_DETECTORS` to `all`
f0409d7 to
edb9972
Compare
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS to allOTEL_EXPERIMENTAL_RESOURCE_DETECTORS to all
xrmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In another PR we added the glob * instead of all since we are sure that it can't be a name for an entry point itself. What do you think? Please fix tox -e lint-opentelemetry-sdk
|
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS to allOTEL_EXPERIMENTAL_RESOURCE_DETECTORS to *
da7d2a4 to
ee794de
Compare
Description
Allow loading all resource detectors by setting
OTEL_EXPERIMENTAL_RESOURCE_DETECTORSto*Fixes #4816
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit test
opentelemetry-sdk/tests/resources/test_resources.py::TestOTELResourceDetector::test_resource_detector_entry_points_allDoes This PR Require a Contrib Repo Change?
Checklist: