Use write access for dashboard approvals#134
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-26 14:10:51 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
There was a problem hiding this comment.
Pull request overview
Updates dashboard approval eligibility to use repository collaborators with write access or higher.
Changes:
- Replaces approver-team lookup with collaborator permission lookup.
- Removes team configuration and organization Members permission.
- Updates tests, dashboard labels, and documentation.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pull-request-dashboard/README.md |
Documents write-access approval behavior. |
.github/workflows/pull-request-dashboard.yml |
Removes approver-team workflow input. |
.github/workflows/pull-request-dashboard-repo.yml |
Removes team input and Members permission. |
.github/scripts/pull-request-dashboard/WEBHOOK_SETUP.md |
Updates GitHub App permission guidance. |
.github/scripts/pull-request-dashboard/test_github_cli.py |
Tests collaborator-based reviewer loading. |
.github/scripts/pull-request-dashboard/test_dashboard.py |
Updates tests for the removed CLI option. |
.github/scripts/pull-request-dashboard/repositories.json |
Removes repository approver-team configuration. |
.github/scripts/pull-request-dashboard/render.py |
Updates approval icon descriptions. |
.github/scripts/pull-request-dashboard/github_cli.py |
Loads reviewers from write-level collaborators. |
.github/scripts/pull-request-dashboard/dashboard.py |
Integrates collaborator-based approval eligibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
The TC has write permissions on every repo, so their approval would be counted as someone with write access but the ruleset may not allow maintainers to merge the PR. It's a small edge case, but maybe it could be confusing?
Otherwise looks good to me, if you think that this is not worth worrying about feel free to merge :)
Determine dashboard approvers from repository collaborators with write access or higher, matching GitHub's green approval checkmarks. Remove per-repository approver-team configuration and the organization Members permission, and update the dashboard legend and documentation accordingly.