Skip to content

Prevent outdated pull request dashboard runs from publishing#144

Open
trask wants to merge 4 commits into
open-telemetry:mainfrom
trask:fix/monotonic-delivery-revisions
Open

Prevent outdated pull request dashboard runs from publishing#144
trask wants to merge 4 commits into
open-telemetry:mainfrom
trask:fix/monotonic-delivery-revisions

Conversation

@trask

@trask trask commented Jul 22, 2026

Copy link
Copy Markdown
Member

Prevent queued pull request dashboard jobs running older code from publishing after a newer dashboard version has taken over. Each target repository records the dashboard state and rendering versions used by the active publisher. A job with older or unrecognized versions exits before posting status comments, reminders, review requests, Slack notifications, or the dashboard issue; current jobs continue normally.

The guard derives its compatibility marker from the dashboard’s existing state and renderer version constants, so bumping one automatically fences older queued jobs without treating unrelated shared-workflows commits as dashboard releases.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 22, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-25 18:05:19 UTC.

  • Waiting on: Maintainers
  • Next step: Merge when ready.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit delivery revision fencing to prevent stale dashboard workers from publishing side effects.

Changes:

  • Persists and claims the highest active delivery revision.
  • Skips delivery and issue publication for inactive revisions.
  • Adds revision and delivery-output tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/pull-request-dashboard-repo.yml Gates issue publication on active delivery revision.
.github/scripts/pull-request-dashboard/state.py Adds revision state persistence and claiming.
.github/scripts/pull-request-dashboard/delivery.py Integrates revision checks and workflow output.
.github/scripts/pull-request-dashboard/test_state.py Tests revision advancement and unreadable state.
.github/scripts/pull-request-dashboard/test_delivery.py Tests active and stale delivery behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/scripts/pull-request-dashboard/delivery.py Outdated
Comment thread .github/scripts/pull-request-dashboard/state.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/scripts/pull-request-dashboard/delivery.py:128

  • The revision check runs only in publish-dashboard, after update-dashboard has already executed dashboard.py and pushed to the same state branch (workflow lines 118–154). A queued lower-revision worker can therefore see a newer state schema as mismatched, regenerate it using old defaults, and commit that downgrade before being skipped here, potentially discarding dashboard state. The revision must also be claimed/checked inside the dashboard-update CAS transactions so stale updaters exit without writing state.
        active_revision = claim_delivery_revision()
        if not active_revision:

@trask trask changed the title Guard dashboard delivery with explicit revisions Guard dashboard delivery with compatibility versions Jul 22, 2026
@trask
trask requested a review from Copilot July 22, 2026 22:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@trask trask changed the title Guard dashboard delivery with compatibility versions Prevent outdated pull request dashboard runs from publishing Jul 22, 2026
@trask
trask marked this pull request as ready for review July 22, 2026 22:28
@trask
trask requested a review from a team as a code owner July 22, 2026 22:28
@trask
trask requested a review from mx-psi July 22, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants