Prevent outdated pull request dashboard runs from publishing#144
Open
trask wants to merge 4 commits into
Open
Conversation
This was referenced Jul 22, 2026
Pull request dashboard statusStatus last refreshed: 2026-07-25 18:05:19 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit delivery revision fencing to prevent stale dashboard workers from publishing side effects.
Changes:
- Persists and claims the highest active delivery revision.
- Skips delivery and issue publication for inactive revisions.
- Adds revision and delivery-output tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pull-request-dashboard-repo.yml |
Gates issue publication on active delivery revision. |
.github/scripts/pull-request-dashboard/state.py |
Adds revision state persistence and claiming. |
.github/scripts/pull-request-dashboard/delivery.py |
Integrates revision checks and workflow output. |
.github/scripts/pull-request-dashboard/test_state.py |
Tests revision advancement and unreadable state. |
.github/scripts/pull-request-dashboard/test_delivery.py |
Tests active and stale delivery behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/scripts/pull-request-dashboard/delivery.py:128
- The revision check runs only in
publish-dashboard, afterupdate-dashboardhas already executeddashboard.pyand pushed to the same state branch (workflow lines 118–154). A queued lower-revision worker can therefore see a newer state schema as mismatched, regenerate it using old defaults, and commit that downgrade before being skipped here, potentially discarding dashboard state. The revision must also be claimed/checked inside the dashboard-update CAS transactions so stale updaters exit without writing state.
active_revision = claim_delivery_revision()
if not active_revision:
…alformed delivery versions
trask
marked this pull request as ready for review
July 22, 2026 22:28
maryliag
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent queued pull request dashboard jobs running older code from publishing after a newer dashboard version has taken over. Each target repository records the dashboard state and rendering versions used by the active publisher. A job with older or unrecognized versions exits before posting status comments, reminders, review requests, Slack notifications, or the dashboard issue; current jobs continue normally.
The guard derives its compatibility marker from the dashboard’s existing state and renderer version constants, so bumping one automatically fences older queued jobs without treating unrelated shared-workflows commits as dashboard releases.