Require an author reply to close top-level PR dashboard feedback - #163
Merged
Conversation
Commits, PR title edits, and PR description edits no longer close a top-level feedback item. None of them is tied to the item it would close, so any push after the feedback arrived closed every open item at once. Also drops "external" from the classifier vocabulary. Feedback blocked on a dependency, decision, or event outside the repository is still the author's to drive, so it is classified as author.
Pull request dashboard statusMerged · refreshed 2026-07-28 15:43 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Pull request overview
Requires explicit author replies to close top-level dashboard feedback and removes external routing and edit-based evidence.
Changes:
- Removes commit, title, and description evidence handling.
- Routes external and unclear feedback to authors.
- Simplifies review fetching, prompts, presentation, and tests.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pull-request-dashboard/README.md |
Documents reply-only closure. |
.github/scripts/pull-request-dashboard/test_top_level_actions.py |
Updates lifecycle tests. |
.github/scripts/pull-request-dashboard/test_route_presentation.py |
Updates route ordering test. |
.github/scripts/pull-request-dashboard/test_render.py |
Updates diagnostic expectations. |
.github/scripts/pull-request-dashboard/test_pr_status_comment.py |
Removes external-route cases. |
.github/scripts/pull-request-dashboard/test_github_cli.py |
Tests simplified review fetching. |
.github/scripts/pull-request-dashboard/test_dashboard.py |
Updates review-fetch mock. |
.github/scripts/pull-request-dashboard/test_dashboard_override.py |
Removes external overrides. |
.github/scripts/pull-request-dashboard/test_copilot_review.py |
Updates review-fetch mocks. |
.github/scripts/pull-request-dashboard/test_author_nudge.py |
Updates review-fetch mock. |
.github/scripts/pull-request-dashboard/route_presentation.py |
Removes external presentation. |
.github/scripts/pull-request-dashboard/RATIONALE.md |
Explains new lifecycle semantics. |
.github/scripts/pull-request-dashboard/github_cli.py |
Removes metadata/title queries. |
.github/scripts/pull-request-dashboard/dashboard.py |
Implements reply-only closure and routing. |
.github/scripts/pull-request-dashboard/dashboard_override.py |
Limits overrides to author routing. |
.github/scripts/pull-request-dashboard/copilot_review.py |
Uses simplified reviews API. |
.github/scripts/pull-request-dashboard/classification.py |
Simplifies classifier vocabularies. |
.github/scripts/pull-request-dashboard/author_nudge.py |
Uses simplified reviews API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pass the feedback author's login as `requester` so the classifier can tell that first-person statements in the body are the reviewer speaking, not the PR author. Classify a link to a reviewer's own pull request or patch as an author action: the author still has to acknowledge, accept, or push back even though the proposed change lives elsewhere. Use the inline prompt's stronger injection hardening in both batch prompts. They are the more exposed surface because they classify up to ten untrusted items in one call, so an instruction inside one item must not affect any other item.
…oard state version
maryliag
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit author reply is now the only thing that closes a top-level PR dashboard feedback item. Commits, PR title edits, and PR description edits no longer count: none of them is tied to the item it would close, so any push after the feedback arrived closed every open item at once.
Also drops
externalfrom the classifier vocabulary and from routing. Feedback blocked on something outside the repository is still the author's to drive, so it is classified asauthor.Ports three rules from the inline-thread prompt to the top-level prompts: the feedback author's login is passed as
requesterso first-person text is attributed to the reviewer, a link to a reviewer's own pull request or patch is an author action, and the batch prompts pick up the stronger prompt-injection hardening. The first two address #151.DASHBOARD_STATE_VERSIONis bumped because the persisted lifecycle semantics change. The classification prompts change too, so the classification cache is invalidated on the first run after this merges.