ci(release-please): pin reusable @1.0.0 and use secrets: inherit#60
Merged
Merged
Conversation
github-workflows-public 1.0.0 reads the App credentials from the org-level RELEASE_PLEASE_CLIENT_ID variable and RELEASE_PLEASE_PRIVATE_KEY secret automatically, so callers only need `secrets: inherit`. PRs opened by the App identity trigger downstream pull_request workflows; PRs opened by the default GITHUB_TOKEN do not (GitHub anti-recursion), which previously left release PRs unmergeable on repos with required checks. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please-reusable.ymlpin to@1.0.0.app-client-id/app-private-keyblock (or add a missingsecrets:block) withsecrets: inherit.Why
1.0.0 of github-workflows-public reads the App credentials from the org-level
RELEASE_PLEASE_CLIENT_IDvariable andRELEASE_PLEASE_PRIVATE_KEYsecret automatically. With this change, release-please PRs are opened by theoce-release-pleaseApp identity, which triggers downstreampull_requestworkflows. PRs opened by the defaultGITHUB_TOKENare suppressed by GitHub's anti-recursion rule, which is why release PRs on repos with required checks have been unmergeable.Verified end-to-end against
openCoreEMR/release-please-testbefore tagging 1.0.0 — see openCoreEMR/github-workflows-public#16 for the run.Test plan
oce-release-please[bot](notgithub-actions[bot]) and that downstream checks run on it