Fix build failures across all KMP targets (JVM, JS, WASM, iOS)#2608
Fix build failures across all KMP targets (JVM, JS, WASM, iOS)#2608Arinyadav1 wants to merge 8 commits intoopenMF:developmentfrom
Conversation
|
Important Review skippedToo many files! This PR contains 226 files, which is 76 over the limit of 150. You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cmp-android/src/main/kotlin/cmp/android/app/ComponentActivityExtensions.kt
Outdated
Show resolved
Hide resolved
cmp-android/src/main/kotlin/cmp/android/app/ComponentActivityExtensions.kt
Outdated
Show resolved
Hide resolved
...re/savings/savingsAccountTransactionReceipt/SavingsAccountTransactionReceiptScreen.wasmJs.kt
Show resolved
Hide resolved
...eature/savings/savingsAccountTransactionReceipt/SavingsAccountTransactionReceiptScreen.js.kt
Show resolved
Hide resolved
feature/report/src/wasmJsMain/kotlin/com/mifos/feature/report/reportDetail/FileHelper.wasmJs.kt
Show resolved
Hide resolved
feature/report/src/jsMain/kotlin/com/mifos/feature/report/reportDetail/FileHelper.js.kt
Show resolved
Hide resolved
...-tracking/src/wasmJsMain/kotlin/com/mifos/feature/path/tracking/PathTrackingScreen.wasmJs.kt
Outdated
Show resolved
Hide resolved
...ure/path-tracking/src/jsMain/kotlin/com/mifos/feature/path/tracking/PathTrackingScreen.js.kt
Outdated
Show resolved
Hide resolved
...e/groups/src/wasmJsMain/kotlin/com/mifos/feature/groups/groupList/GroupsListScreen.wasmJs.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/jsMain/kotlin/com/mifos/feature/groups/groupList/GroupsListScreen.js.kt
Outdated
Show resolved
Hide resolved
...ure/client/src/wasmJsMain/kotlin/com/mifos/feature/client/charges/ShowClientCharge.wasmJs.kt
Outdated
Show resolved
Hide resolved
feature/client/src/jsMain/kotlin/com/mifos/feature/client/charges/ShowClientCharge.js.kt
Outdated
Show resolved
Hide resolved
...nter/src/wasmJsMain/kotlin/com/mifos/feature/center/centerList/ui/CenterListScreen.wasmJs.kt
Outdated
Show resolved
Hide resolved
feature/center/src/jsMain/kotlin/com/mifos/feature/center/centerList/ui/CenterListScreen.js.kt
Outdated
Show resolved
Hide resolved
| val appPrivateInternalStorage = FileKit.filesDir | ||
| val appInternalStorage = FileKit.databasesDir | ||
| // TODO(KMP): cacheDir is supported on Android, iOS, Desktop | ||
| // ❌ NOT supported on Web/WASM targets |
There was a problem hiding this comment.
Can you please remove the cross emoji from the comments?
| companion object { | ||
| const val VERSION = 2 | ||
|
|
||
| val MIGRATION_1_2 = object : Migration(1, 2) { |
There was a problem hiding this comment.
Can you please tell us the reason for removing this migration?
| } | ||
|
|
||
| @TypeConverter | ||
| fun toCurrencyToCurrency(json: String?): Currency? { |
There was a problem hiding this comment.
| fun toCurrencyToCurrency(json: String?): Currency? { | |
| fun toCurrency(json: String?): Currency? { |
| companion object { | ||
| const val VERSION = 2 | ||
|
|
||
| val MIGRATION_1_2 = object : Migration(1, 2) { |
There was a problem hiding this comment.
Same as previously pointed out regarding migration, please review.
|
|
||
| companion object { | ||
| const val VERSION = 2 | ||
|
|
| val resourceId: String, | ||
| ) : Parcelable { | ||
|
|
||
| @IgnoredOnParcel |
There was a problem hiding this comment.
Can you tell us the reason for adding @IgnoreOnParcel on primitive type?
| var officeId: Int? = null, | ||
|
|
||
| @IgnoredOnParcel | ||
| @param:IgnoredOnParcel |
There was a problem hiding this comment.
Some places use the @param, while others do not. Please review and ensure consistency across updated files.
| selectedItems: SelectedItemsState, | ||
| onRefresh: () -> Unit, | ||
| onCenterSelect: (Int) -> Unit, | ||
| modifier: androidx.compose.ui.Modifier, |
There was a problem hiding this comment.
Please move the relevant part to the import section.
| selectedItems: SelectedItemsState, | ||
| onRefresh: () -> Unit, | ||
| onCenterSelect: (Int) -> Unit, | ||
| modifier: androidx.compose.ui.Modifier, |
|
|
||
| @Composable | ||
| internal actual fun GroupsListRoute( | ||
| paddingValues: androidx.compose.foundation.layout.PaddingValues, |
There was a problem hiding this comment.
Please move this to import section.
|
|
||
| @Composable | ||
| internal actual fun GroupsListRoute( | ||
| paddingValues: androidx.compose.foundation.layout.PaddingValues, |
|
@Arinyadav1 I hope you have figured out the FileKit part, since it will break several screens as those parts have been commented out. Please make sure that it is resolved in the next PR. Also, ensure that the image cropping issue is taken care of in another PR immediately after that. |
|
@biplab1 Yeah sure after merge this PR I will fix that issue also |
|
|
@biplab1 please review it again |
2 participants
Fixes - Jira-#644