Merged
Conversation
ax3l
force-pushed
the
fix-move-force-ps1
branch
2 times, most recently
from
e22c79f to
19d9bb9
Compare
ax3l
added
continuous integration
and removed
continuous deployment
ax3l
force-pushed
the
fix-move-force-ps1
branch
from
19d9bb9 to
0d6c9a2
Compare
Use force to address for tge `legacy_datasets.tar`
```
Move-Item : Cannot create a file when that file already exists.
At C:\projects\openpmd-api\share\openPMD\download_samples.ps1:30 char:1
+ Move-Item -Path legacy_datasets\* samples\git-sample\legacy\
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : WriteError: (C:\projects\ope...5.0-hdf5-plugin:DirectoryInfo) [Move-Item], IOException
+ FullyQualifiedErrorId : MoveDirectoryItemIOError,Microsoft.PowerShell.Commands.MoveItemCommand
```
Architecture not part of `-G` anymore, maybe `-A x64`
ax3l
force-pushed
the
fix-move-force-ps1
branch
from
0d6c9a2 to
39af352
Compare
franzpoeschel
approved these changes
Jan 23, 2026
Member
Author
|
Yay, only to fails left: Unittest.pyExample.py.7_extended_write_serial |
ax3l
force-pushed
the
fix-move-force-ps1
branch
from
1fa68ad to
4045aa2
Compare
ax3l
added
bug
affects latest release
internal
machine/system
ax3l
force-pushed
the
fix-move-force-ps1
branch
from
4045aa2 to
085ef1c
Compare
Fix: `TypeError: data type 'ulong' not understood` on GCC 9 w/ Python 3.10 on Linux.
Member
Author
|
On CF, we further see on Win64 these linker errors: conda-forge/openpmd-api-feedstock#130 |
Slightly more consistent
Member
Author
|
Ah, the patch above from Franz fixes exactly that. Moved that to CF. |
Member
Author
|
Not sure what is on with that Update: Ahhh, GH status
|
ax3l
commented
Jan 26, 2026
ax3l
commented
Jan 26, 2026
Comment on lines
162
to
+166
| Datatype dtype = determineDatatype<T>(); | ||
| if (dtype != getDatatype()) | ||
| if (dtype != getDatatype() && !isSameInteger<T>(getDatatype()) && | ||
| !isSameFloatingPoint<T>(getDatatype()) && | ||
| !isSameComplexFloatingPoint<T>(getDatatype()) && | ||
| !isSameChar<T>(getDatatype())) |
Member
Author
There was a problem hiding this comment.
Not urgently needed but sensible.
We should group these together into a single call like isEquivalentRepresentation<T>(getDatatype()) where we use it in the code base.
Contributor
There was a problem hiding this comment.
Our Datatype equality operator already has these semantics:
/** Comparison for two Datatypes
*
* Besides returning true for the same types, identical implementations on
* some platforms, e.g. if long and long long are the same or double and
* long double will also return true.
*/
inline bool isSame(openPMD::Datatype const d, openPMD::Datatype const e)
{
// exact same type
if (static_cast<int>(d) == static_cast<int>(e))
return true;
bool d_is_vec = isVector(d);
bool e_is_vec = isVector(e);
// same int
bool d_is_int, d_is_sig;
std::tie(d_is_int, d_is_sig) = isInteger(d);
bool e_is_int, e_is_sig;
std::tie(e_is_int, e_is_sig) = isInteger(e);
if (d_is_int && e_is_int && d_is_vec == e_is_vec && d_is_sig == e_is_sig &&
toBits(d) == toBits(e))
return true;
// same float
bool d_is_fp = isFloatingPoint(d);
bool e_is_fp = isFloatingPoint(e);
if (d_is_fp && e_is_fp && d_is_vec == e_is_vec && toBits(d) == toBits(e))
return true;
// same complex floating point
bool d_is_cfp = isComplexFloatingPoint(d);
bool e_is_cfp = isComplexFloatingPoint(e);
if (d_is_cfp && e_is_cfp && d_is_vec == e_is_vec && toBits(d) == toBits(e))
return true;
return false;
}We should try merging your code into that instead of creating a new call
Member
Author
|
Woho, we did it! Thanks for the help, @franzpoeschel 🤝 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake Generator line for 64bit build was outdated and does not include the architecture anymore.
Use force to address for the
legacy_datasets.tar