This is the wrong pull request, so please disregard it. ~~docs: disallow squash in landing workflow~~#892
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 30, 2026, 9:13 AM ET / 13:13 UTC. Summary Reproducibility: not applicable. this is repository workflow documentation, not a reproducible runtime bug. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this only after maintainers confirm that normal merge commits should be the default landing path and squash merges should be forbidden in AGENTS.md. Do we have a high-confidence way to reproduce the issue? Not applicable; this is repository workflow documentation, not a reproducible runtime bug. Is this the best way to solve the issue? Unclear; the patch is coherent, but forbidding squash merges is a maintainer workflow decision rather than a self-evident docs correction. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 213ddb60d7d1. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
I accidentally opened a PR against gog. Please ignore it as noise.