Skip to content

Added Strait of Florida Map#3434

Open
RaptorJesus67 wants to merge 1 commit intoopenfrontio:mainfrom
RaptorJesus67:main
Open

Added Strait of Florida Map#3434
RaptorJesus67 wants to merge 1 commit intoopenfrontio:mainfrom
RaptorJesus67:main

Conversation

@RaptorJesus67
Copy link

@RaptorJesus67 RaptorJesus67 commented Mar 15, 2026

If this PR fixes an issue, link it below. If not, delete these two lines.
Resolves #(issue number)

Description:

Adding a New Map that would be great for Trading/Trademaxxing with the Strait of Florida between Florida and Cuba. Iplayed the map a couple of times, and I see a lot of potential for it being a fun trading map.

image

Please complete the following:

  • [X ] I have added screenshots for all UI updates
  • [X ] I process any text displayed to the user through translateText() and I've added it to the en.json file
  • [X ] I have added relevant tests to the test directory
  • [X ] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

Discord: KCMitch

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

Walkthrough

This PR adds a new map location called "Strait of Florida" to the game. The addition includes asset files with map metadata and nation coordinates, configuration updates across multiple resource files, and registration in the game's map type system and playlist frequency settings.

Changes

Cohort / File(s) Summary
Map Assets
map-generator/assets/maps/straitofflorida/info.json, resources/maps/straitofflorida/manifest.json
Introduces map definition and manifest with coordinates for Cuban locales, Florida cities, and Caribbean regions including flag identifiers and tile dimensions.
Game Configuration
src/core/game/Game.ts, src/server/MapPlaylist.ts, map-generator/main.go
Registers StraitOfFlorida in the GameMapType enum, assigns it to the regional map category, adds it to the map registry, and sets a frequency value of 4 for map selection.
Resource Data
resources/countries.json, resources/lang/en.json
Adds country/region entries for Cuban and Florida locations with continent and code metadata; includes map name localization string and corrects JSON formatting with a trailing comma.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🗺️ A strait flows through the morning light,
Between Havana's palms and Florida's white.
New nations marked with flags so bright,
Geography blooms in data's sight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding a new map called Strait of Florida to the game.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly describes adding a new map for the Strait of Florida region intended for trading gameplay, with reference to testing and screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

@RaptorJesus67
Copy link
Author

Bumping for review. All of the code looks clean according to the auto checks. Just needs a mod to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant