Skip to content

Added Moldova Map#3466

Open
flucci14 wants to merge 1 commit intoopenfrontio:mainfrom
flucci14:moldova
Open

Added Moldova Map#3466
flucci14 wants to merge 1 commit intoopenfrontio:mainfrom
flucci14:moldova

Conversation

@flucci14
Copy link

Description:

I added the moldova map. It is the layout of the country moldova, cut out and illustrated as an Island.

--> Moldova channel (in Discord/maps/moldova)

--> 18 W's

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

fibsx

image1 image1 grafik grafik

size 1500x1500

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e17e9a3e-7e8c-405a-9008-9b1eaf5be597

📥 Commits

Reviewing files that changed from the base of the PR and between afdb04a and b82c3c3.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/moldova/image.png is excluded by !**/*.png
  • resources/maps/moldova/map.bin is excluded by !**/*.bin
  • resources/maps/moldova/map16x.bin is excluded by !**/*.bin
  • resources/maps/moldova/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (7)
  • map-generator/assets/maps/moldova/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/moldova/manifest.json
  • resources/maps/moldova/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

Walkthrough

This pull request adds support for a new map called "Moldova" to the game. The changes include map data files, type definitions, localization strings, and playlist configuration across Go backend and TypeScript frontend to enable the new map for game generation and play.

Changes

Cohort / File(s) Summary
Map Data Files
map-generator/assets/maps/moldova/info.json, resources/maps/moldova/manifest.json
New Moldova map metadata including dimensions (1500×1500 base), six nations with coordinates and strength values, and variant sizes (4x and 16x).
Go Backend
map-generator/main.go
Added Moldova entry to the maps registry for inclusion in concurrent map generation pipeline.
TypeScript Types
src/core/game/Game.ts
Extended GameMapType enum with Moldova and added it to the regional map category within mapCategories.
Localization & Playlist
resources/lang/en.json, src/server/MapPlaylist.ts
Added English localization key for Moldova and assigned it a frequency value of 8 in the game playlist configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🗺️ A new region joins the fold,

Moldova's story to be told,

Six nations rise on digital land,

Data flows across the stand,

The map expands, the game grows bold! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Added Moldova Map' directly and accurately describes the main change in the pull request - the addition of a new Moldova map with supporting data and configuration files.
Description check ✅ Passed The description clearly relates to the changeset by explaining that a Moldova map was added as a country layout illustrated as an island, with relevant context about Discord channels and testing completion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant