Skip to content

Extend statepoint dump feature to support dumps from the last N batches#3655

Open
pranavkantgaur wants to merge 7 commits intoopenmc-dev:developfrom
pranavkantgaur:3360_copilot_patch
Open

Extend statepoint dump feature to support dumps from the last N batches#3655
pranavkantgaur wants to merge 7 commits intoopenmc-dev:developfrom
pranavkantgaur:3360_copilot_patch

Conversation

@pranavkantgaur
Copy link
Copy Markdown
Contributor

@pranavkantgaur pranavkantgaur commented Nov 25, 2025

Description

This MR extends the statepoint dump feature as documented here to support dumping statepoints for last N batches. It is authored entirely using Copilot and reviewed by me.

Currently, the 'batches' key takes a list of batch numbers for which statepoint files should be saved, for instance: model.settings.statepoint = {'batches': range(5, n + 5, 5)}
this MR extends this to support configuration as:
settings.statepoint = {'batches': [10, 20, 30, -3]}, to write statepoints at specific batches and also keep the last 3 completed
batches (indicated by '-3').

Fixes #3630

Checklist

@yrrepy
Copy link
Copy Markdown
Contributor

yrrepy commented Mar 27, 2026

Like the initiative!

I think it should be it's own element, OpenMC tends to be more explicit than older codes that used switches and negatives to de-note different mechanisms.

something like this

  <state_point>
    <batches>10 20 30 </batches>
    <running_batches>3</running_batches>
  </state_point>

I personally would jettison the new tests, and I think the core code could be fair bit more compact.
The documentation is also too verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Enhancement: Regular Statepoint Dumps

2 participants