HYPERFLEET-1056 - bug: Update adapter task configmap to take in files…#172
HYPERFLEET-1056 - bug: Update adapter task configmap to take in files…#172ma-hill wants to merge 1 commit into
Conversation
… outside of adapter chart
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Summary
Enhances the adapter task ConfigMap template to support both inline YAML/string content and chart-local file references. Previously,
adapterTaskConfig.filesonly supported file paths within the chart directory using.Files.Get. This change allows users to also provide direct YAML content or multi-line strings as values, enabling more flexible configuration patterns for adapter task definitions that don't require storing content in separate files.Jira Issue
HYPERFLEET-1056
Changes
configmap-adapter-task.yamltemplate to detect whetheradapterTaskConfig.filesvalues are strings or structured YAML.Files.Get(chart-local file path).Files.Getreturns empty (file not found in chart), the string value is treated as direct content and rendered inlinetoYamlNotes
This change is fully backward compatible. Existing Helm values that reference chart-local files (e.g.,
adapterTaskConfig.files.config: "configs/my-config.yaml") will continue to work exactly as before. The enhancement only activates when the file doesn't exist in the chart, or when the value is structured YAML rather than a string path.