Skip to content

HYPERFLEET-1056 - bug: Update adapter task configmap to take in files…#172

Draft
ma-hill wants to merge 1 commit into
openshift-hyperfleet:mainfrom
ma-hill:HYPERFLEET-1056
Draft

HYPERFLEET-1056 - bug: Update adapter task configmap to take in files…#172
ma-hill wants to merge 1 commit into
openshift-hyperfleet:mainfrom
ma-hill:HYPERFLEET-1056

Conversation

@ma-hill
Copy link
Copy Markdown
Contributor

@ma-hill ma-hill commented May 29, 2026

Summary

Enhances the adapter task ConfigMap template to support both inline YAML/string content and chart-local file references. Previously, adapterTaskConfig.files only supported file paths within the chart directory using .Files.Get. This change allows users to also provide direct YAML content or multi-line strings as values, enabling more flexible configuration patterns for adapter task definitions that don't require storing content in separate files.

Jira Issue

HYPERFLEET-1056

Changes

  • Updated configmap-adapter-task.yaml template to detect whether adapterTaskConfig.files values are strings or structured YAML
  • For string values, the template first attempts to load via .Files.Get (chart-local file path)
  • If .Files.Get returns empty (file not found in chart), the string value is treated as direct content and rendered inline
  • For non-string values (maps, arrays), the template renders them directly using toYaml
  • This maintains backward compatibility: existing file path references continue to work as before

Notes

This change is fully backward compatible. Existing Helm values that reference chart-local files (e.g., adapterTaskConfig.files.config: "configs/my-config.yaml") will continue to work exactly as before. The enhancement only activates when the file doesn't exist in the chart, or when the value is structured YAML rather than a string path.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 29, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mbrudnoy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (2)
  • do-not-merge/work-in-progress
  • do-not-merge/hold

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 37dcded4-71db-41b2-b568-f7626d08a449

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant