GSM: updater service accounts are opt-in per collection - #620
Merged
openshift-merge-bot[bot] merged 2 commits intoSep 9, 2026
Merged
Conversation
openshift-ci
Bot
added
the
approved
The page never mentioned them, which was fine while every collection got one automatically. They are becoming opt-in, so a team that needs one now has to ask, and a team that does not should know it has nothing to do. Says what the Rover group already gets, when a service account is the answer instead, how to request it, where the key ends up, and that withdrawing one revokes its keys.
psalajova
force-pushed
the
gsm-updater-service-accounts
branch
from
September 7, 2026 15:34
704d7ee to
4c12c57
Compare
…tion The page said each collection has a dedicated service account and described get-sa as returning the one already associated with any collection. Service accounts are becoming opt-in, so for most collections get-sa will have nothing to return. Corrects the four places that claimed otherwise and adds a troubleshooting entry, since a failing get-sa on a collection the user can otherwise manage looks like a permissions problem rather than a collection that simply has no service account.
psalajova
changed the title
Contributor
|
@psalajova: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Prucek
approved these changes
Sep 9, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Prucek, psalajova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now every secret collection got a GCP updater service account automatically. openshift/ci-tools#5401 makes them opt-in, so teams that need one have to ask for it — and teams that do not should be able to tell that they have nothing to do.
adding-a-new-secret-to-ci-gsm.md— new subsection in Step 1: what the Rover group already gets, when a service account is the answer instead (automation that cannot authenticate as a group member, e.g. a Jenkins job), how to request one, where its key ends up, and that withdrawing one revokes its keys.cli-secret-manager.md— this page was actively wrong once the behaviour changes. It said "Each secret collection has a dedicated write-only service account associated with it" and describedsm get-saas returning the credentials for the one "already associated with the specified collection". For most collections there will be nothing to return. Corrected in the four places that claimed otherwise, plus a troubleshooting entry — a failingget-saon a collection you can otherwise manage reads like a permissions problem, when it just means the collection has no service account.Depends on openshift/ci-tools#5401 and openshift/release#84712.