Skip to content

Checks for new tests that may not work on hypershift/microshift/ipv6/disconnected#6

Merged
openshift-merge-bot[bot] merged 6 commits intoopenshift:mainfrom
dgoodwin:less-reverts-1
Mar 13, 2026
Merged

Checks for new tests that may not work on hypershift/microshift/ipv6/disconnected#6
openshift-merge-bot[bot] merged 6 commits intoopenshift:mainfrom
dgoodwin:less-reverts-1

Conversation

@dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Mar 10, 2026

First batch of checks to try to reduce reverts for new tests that will not work on microshift, hypershift, or ipv6/disconnected. Experimental and may need iteration.

  • Add a check that tests are compatible with microshift
  • Add a check for SNO test compat
  • Add a check for ipv6 and disconnected test compat
  • Expand microshift check

@dgoodwin dgoodwin changed the title less reverts 1 Checks for new tests that may not work on hypershift/microshift/ipv6/disconnected Mar 10, 2026
@openshift-ci openshift-ci bot requested review from mkowalski and stbenjam March 10, 2026 14:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2026
Copy link
Member

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned about the sheer verbosity of these checks, and how they'll play with CodeRabbit's context windows. I haven't found good docs about this, but I guess we'll notice if it becomes a problem.

There are already annotations in test names (as well as via OTE) that limit test execution, is it smart enough to not flag those tests? I don't see where we explicitly say that.

@dgoodwin
Copy link
Contributor Author

My research indicates coderabbit checks are all their own agent, so verbose single checks do not accumulate into a huge mess of context for an overall review.

I've updated with better guarding for already skipped tests, and added the ipv6 sprintf checking. You can see some of my testing over here with the original version of the PR, and yes coderabbit DOES read config from the pr it's reviewing so this is a way we can test changes. Next time I might add dummy code to this repo and remove it before merging.

openshift/origin#30871

@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b196807 into openshift:main Mar 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants