Checks for new tests that may not work on hypershift/microshift/ipv6/disconnected#6
Conversation
stbenjam
left a comment
There was a problem hiding this comment.
I am concerned about the sheer verbosity of these checks, and how they'll play with CodeRabbit's context windows. I haven't found good docs about this, but I guess we'll notice if it becomes a problem.
There are already annotations in test names (as well as via OTE) that limit test execution, is it smart enough to not flag those tests? I don't see where we explicitly say that.
|
My research indicates coderabbit checks are all their own agent, so verbose single checks do not accumulate into a huge mess of context for an overall review. I've updated with better guarding for already skipped tests, and added the ipv6 sprintf checking. You can see some of my testing over here with the original version of the PR, and yes coderabbit DOES read config from the pr it's reviewing so this is a way we can test changes. Next time I might add dummy code to this repo and remove it before merging. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First batch of checks to try to reduce reverts for new tests that will not work on microshift, hypershift, or ipv6/disconnected. Experimental and may need iteration.