Skip to content

OCPBUGS-77941: Remove cluster-api-provider-libvirt references#1472

Open
sdodson wants to merge 1 commit intoopenshift:mainfrom
sdodson:main
Open

OCPBUGS-77941: Remove cluster-api-provider-libvirt references#1472
sdodson wants to merge 1 commit intoopenshift:mainfrom
sdodson:main

Conversation

@sdodson
Copy link
Member

@sdodson sdodson commented Mar 6, 2026

Summary by CodeRabbit

  • Documentation

    • Removed Libvirt platform references from documentation and configuration files
  • Chores

    • Removed Libvirt-related entries from image configurations and removed associated test coverage

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 6, 2026
@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Jira Issue OCPBUGS-77941, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huali9

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from huali9 March 6, 2026 19:08
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 72f81e90-9f83-4792-99ad-8c4600318f0b

📥 Commits

Reviewing files that changed from the base of the PR and between 8846555 and e74bb11.

📒 Files selected for processing (7)
  • README.md
  • docs/dev/hacking-guide.md
  • install/0000_30_machine-api-operator_01_images.configmap.yaml
  • install/image-references
  • pkg/operator/config.go
  • pkg/operator/config_test.go
  • pkg/operator/operator_test.go
💤 Files with no reviewable changes (7)
  • pkg/operator/operator_test.go
  • pkg/operator/config_test.go
  • README.md
  • install/0000_30_machine-api-operator_01_images.configmap.yaml
  • pkg/operator/config.go
  • docs/dev/hacking-guide.md
  • install/image-references

Walkthrough

This pull request removes all Libvirt-related support from the machine-api-operator codebase, including image references from ConfigMaps and image streams, the ClusterAPIControllerLibvirt struct field, and all corresponding Libvirt platform test cases across multiple test files.

Changes

Cohort / File(s) Summary
Documentation and Configuration References
README.md, docs/dev/hacking-guide.md, install/image-references, install/0000_30_machine-api-operator_01_images.configmap.yaml
Removed all Libvirt-related entries from documentation, ConfigMap images object, and image stream references including the libvirt-machine-controllers DockerImage.
Configuration Code
pkg/operator/config.go
Removed ClusterAPIControllerLibvirt field from the Images struct and eliminated the Libvirt platform case from getProviderControllerFromImages function.
Test Files
pkg/operator/config_test.go, pkg/operator/operator_test.go
Removed all Libvirt-related test cases and assertions including expectedLibvirtImage constant and LibvirtPlatformType test paths from multiple test functions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'OCPBUGS-77941: Remove cluster-api-provider-libvirt references' directly and clearly summarizes the main change: systematic removal of libvirt-related references across documentation, configuration, and test files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The PR removes Libvirt test cases from traditional Go test functions with static, deterministic names containing no dynamic content like timestamps, UUIDs, or generated identifiers.
Test Structure And Quality ✅ Passed PR modifies standard Go unit tests (not Ginkgo tests), maintaining proper cleanup, meaningful error messages, and appropriate timeouts without using Ginkgo patterns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Jira Issue OCPBUGS-77941, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huali9

Details

In response to this:

Summary by CodeRabbit

  • Documentation

  • Removed Libvirt platform references from documentation and configuration files

  • Chores

  • Removed Libvirt-related entries from image configurations and removed associated test coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member Author

sdodson commented Mar 6, 2026

@JoelSpeed following after your pattern in ovirt removal here, i notice the platform type was not removed from openshift/api I assume it can never be removed there?

@sdodson
Copy link
Member Author

sdodson commented Mar 6, 2026

/jira backport release-4.21

@openshift-ci-robot
Copy link
Contributor

@sdodson: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

Details

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

@sdodson: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@sdodson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 e74bb11 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm
/approve

I assume it can never be removed there?

I think we can probably do some cleanup there as we hit 5.0, since we should be confident no one is upgrading into 5.0 on the various platforms no longer supported. Alibaba too needs cleanup

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants