Skip to content

NO-ISSUE: use reqpart in devenv kickstart for RHEL 10 BIOS+GPT compatibility #7048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copejon wants to merge 1 commit into from
+15 −9
Closed

NO-ISSUE: use reqpart in devenv kickstart for RHEL 10 BIOS+GPT compatibility #7048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions scripts/devenv-builder/config/kickstart.ks.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,22 @@ reboot
# Configure network to use DHCP and activate on boot
network --bootproto=dhcp --device=link --activate --onboot=on --hostname=REPLACE_HOST_NAME --noipv6

# Partition disk with a 1GB boot XFS partition and an LVM volume containing system root
# The remainder of the volume will be used by the CSI driver for storing data
# Partition disk with an LVM volume containing system root.
# Boot partitions are created automatically by anaconda based on the
# firmware type (UEFI or BIOS) using the reqpart directive.
# The remainder of the volume will be used by the CSI driver for storing data.
#
# For example, a 50GB disk with 45GB system root would be partitioned in the following way:
# For example, a 50GB disk with 45GB system root would be partitioned as:
#
# NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
# sda 8:0 0 50G 0 disk
# ├─sda1 8:1 0 200M 0 part /boot/efi
# ├─sda2 8:1 0 800M 0 part /boot
# └─sda2 8:2 0 49G 0 part
# sda 8:0 0 50G 0 disk
# ├─sda1 8:1 0 1G 0 part /boot
# └─sda2 8:2 0 49G 0 part
# └─rhel-root 253:0 0 45G 0 lvm /sysroot
#
zerombr
clearpart --all --initlabel
part /boot/efi --fstype=efi --size=200
part /boot --fstype=xfs --asprimary --size=800
reqpart --add-boot
part swap --fstype=swap --size=REPLACE_SWAP_SIZE
part pv.01 --grow
volgroup rhel pv.01
Expand Down
6 changes: 6 additions & 0 deletions scripts/devenv-builder/manage-vm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ function get_base_isofile {
9.*)
echo "rhel-${rhel_version}-$(uname -m)-dvd.iso"
;;
10)
echo "rhel-10.2-$(uname -m)-dvd.iso"
;;
10.*)
echo "rhel-${rhel_version}-$(uname -m)-dvd.iso"
;;
Comment on lines +64 to +69

@coderabbitai coderabbitai Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Document RHEL 10 in the -v help text.

These branches add RHEL 10 support, but help still says the major-version example is "9" and only shows "8.7" for a minor version. Update the corresponding usage text to mention 10/10.2, so users discover the new supported version.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/devenv-builder/manage-vm.sh` around lines 64 - 69, Update the version
option usage text in the help output to include RHEL 10 examples, changing the
major-version example to 10 and the minor-version example to 10.2 while
preserving the existing supported-version guidance.

*)
echo "Unknown RHEL version ${rhel_version}" 1>&2
exit 1
Expand Down