Skip to content

SPLAT-2672: ote/ccm-aws removing binary while migrating to CCCMO#30869

Open
mtulio wants to merge 1 commit intoopenshift:mainfrom
mtulio:ote-rm-ccm-aws-SPLAT-2672
Open

SPLAT-2672: ote/ccm-aws removing binary while migrating to CCCMO#30869
mtulio wants to merge 1 commit intoopenshift:mainfrom
mtulio:ote-rm-ccm-aws-SPLAT-2672

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Mar 12, 2026

Removing CCM-AWS OTE binary extraction temporarialy to unblock upstream sync. This will be migrated to CCCMO project to prevent future issues and keep the OTE extractions.

See also:
openshift/cluster-cloud-controller-manager-operator#437
#30864

Summary by CodeRabbit

  • Chores
    • Removed AWS Cloud Controller Manager test binary entry from test infrastructure.

Removing CCM-AWS OTE binary extraction temporarialy to unblock upstream
sync. This will be migrated to CCCMO project to prevent future issues
and keep the OTE extractions.

See also:
openshift/cluster-cloud-controller-manager-operator#437
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Removing CCM-AWS OTE binary extraction temporarialy to unblock upstream sync. This will be migrated to CCCMO project to prevent future issues and keep the OTE extractions.

See also:
openshift/cluster-cloud-controller-manager-operator#437

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

Walkthrough

A single AWS Cloud Controller Manager extension binary entry is removed from the public extensionBinaries registry in pkg/test/extensions/binary.go. The change reduces the set of available extension test binaries with no other functional modifications.

Changes

Cohort / File(s) Summary
Extension Binary Registry
pkg/test/extensions/binary.go
Removed AWS Cloud Controller Manager extension binary entry from extensionBinaries registry (imageTag: "aws-cloud-controller-manager", binaryPath: "/usr/bin/aws-cloud-controller-manager-tests-ext.gz").

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the AWS Cloud Controller Manager binary from the extension registry while migrating to CCCMO, which directly corresponds to the code change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The PR removes aws-cloud-controller-manager from extensionBinaries registry in pkg/test/extensions/binary.go, a configuration module without Ginkgo test definitions, making the test stability check inapplicable.
Test Structure And Quality ✅ Passed PR modifies pkg/test/extensions/binary.go, a test infrastructure configuration file, not Ginkgo test code.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan for PR comments
  • Generate coding plan

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Removing CCM-AWS OTE binary extraction temporarialy to unblock upstream sync. This will be migrated to CCCMO project to prevent future issues and keep the OTE extractions.

See also:
openshift/cluster-cloud-controller-manager-operator#437
#30864

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning March 12, 2026 13:59
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Removing CCM-AWS OTE binary extraction temporarialy to unblock upstream sync. This will be migrated to CCCMO project to prevent future issues and keep the OTE extractions.

See also:
openshift/cluster-cloud-controller-manager-operator#437
#30864

Summary by CodeRabbit

  • Chores
  • Removed AWS Cloud Controller Manager test binary entry from test infrastructure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2026
@mtulio
Copy link
Contributor Author

mtulio commented Mar 12, 2026

Look at the job 2032101141717716992, I can't see the binary aws-cloud-controller-manager-tests-ext extracted anymore, as well no tests with prefix [cloud-provider-aws-e2e is in the execution list.

e2e-aws-ovn-fips, e2e-aws-ovn-microshift, and e2e-aws-ovn-serial-2of2 have been failed for unrelated reason.

@mtulio
Copy link
Contributor Author

mtulio commented Mar 12, 2026

/pipeline required

@mtulio
Copy link
Contributor Author

mtulio commented Mar 12, 2026

/verified by #30869 (comment)

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 12, 2026
@openshift-ci-robot
Copy link

@mtulio: This PR has been marked as verified by https://github.com/openshift/origin/pull/30869#issuecomment-4048773076.

Details

In response to this:

/verified by #30869 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@sosiouxme
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, mtulio, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2026
@damdo
Copy link
Member

damdo commented Mar 13, 2026

/retest

1 similar comment
@damdo
Copy link
Member

damdo commented Mar 13, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2026

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-microshift 8309088 link true /test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented Mar 13, 2026

/retest-required

@damdo
Copy link
Member

damdo commented Mar 13, 2026

@mtulio do we think the microshift failure is unrelated? It looks like it permafails to me: https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-origin-main-e2e-aws-ovn-microshift

Can we override it @sosiouxme ? TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants