Rename EXTRA_FLAGS in node-density and enable churning in nd and nd-cni#75826
Conversation
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
|
/ph-rehearse ? |
|
/pj-rehearse periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-payload-control-plane-6nodes |
|
@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
rsevilla87
force-pushed
the
nd-density-extra-flags
branch
from
3ddb3b1 to
9416777
Compare
|
/pj-rehearse periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-payload-control-plane-6nodes |
|
@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/cc @davdhacs |
|
/cc @mtodor |
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
davdhacs
left a comment
davdhacs
left a comment
There was a problem hiding this comment.
+1
thank you! We'll PR changing our test if there is followup/fixes still needed in our tests.
|
[REHEARSALNOTIFIER]
A total of 94 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/lgtm |
rsevilla87
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davdhacs, rsevilla87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@rsevilla87: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
…ni (openshift#75826) * Rename EXTRA_FLAGS in node-density Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Linting Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Remove from stackrox Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Enable churning in node-density-cni Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Lints Signed-off-by: Raul Sevilla <rsevilla@redhat.com> --------- Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
…ni (openshift#75826) * Rename EXTRA_FLAGS in node-density Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Linting Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Remove from stackrox Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Enable churning in node-density-cni Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Lints Signed-off-by: Raul Sevilla <rsevilla@redhat.com> --------- Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
4 participants
Deprecate the variable EXTRA_FLAGS in node-density workloads and replace it for a per workload variable, in this case ND_EXTRA_FLAGS to prevent reusing the same variable name across different jobs
The change in ACS was necessary because EXTRA_FLAGS is not used in any of the jobs of the stackrox-perfscale chain, only the variable CD_V2_EXTRA_FLAGS is necessary as is the only one that had any effect previously.
/cc @mohit-sheth @jtaleric