prow: add registry-pull preset to provide jobs with pull credentials#75830
Conversation
|
Skipping CI for Draft Pull Request. |
Regenerate all Prowjob definitions using the modified prowgen that uses the preset-ci-operator-image-pull Prow preset instead of inlining the pull-secret volume and volumeMount in every job PodSpec. Per-job changes: - Added label: preset-ci-operator-image-pull: "true" - Removed: pull-secret volumeMount (3 lines) - Removed: pull-secret volume definition (3 lines) - Net: -5 lines per job 25,666 files changed, -633K lines net reduction. Depends on: - Preset definition: openshift#75830 - Prowgen change: openshift/ci-tools#4994 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/test prow-config |
6fbb758 to
d2694cd
Compare
Add a Prow preset that provides the registry pull credentials volume and volumeMount to Prowjobs labeled with presets.ci.openshift.io/registry-pull: "true". This is a proof of concept for using compositional Prow presets to deduplicate boilerplate from the 126K+ generated ci-operator Prowjobs. Each preset covers one logical domain and can be independently composed. The corresponding prowgen change will add this label to all generated jobs and stops inlining the pull-secret volume/mount in the PodSpec. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d2694cd to
42671df
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@petr-muller: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add a Prow preset that provides the registry pull credentials volume and volumeMount to Prowjobs labeled with presets.ci.openshift.io/registry-pull: "true". This is a proof of concept for using compositional Prow presets to deduplicate boilerplate from the 126K+ generated ci-operator Prowjobs. Each preset covers one logical domain and can be independently composed. The corresponding prowgen change will add this label to all generated jobs and stops inlining the pull-secret volume/mount in the PodSpec. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Add a Prow preset that provides the registry pull credentials volume and volumeMount to Prowjobs labeled with presets.ci.openshift.io/registry-pull: "true". This is a proof of concept for using compositional Prow presets to deduplicate boilerplate from the 126K+ generated ci-operator Prowjobs. Each preset covers one logical domain and can be independently composed. The corresponding prowgen change will add this label to all generated jobs and stops inlining the pull-secret volume/mount in the PodSpec. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Proof of concept for using Prow presets to deduplicate boilerplate from the 126K+ generated ci-operator Prowjob definitions.
This PR adds a preset to the Prow config that provides the
pull-secretvolume and volumeMount to any Prowjob labeled withpresets.ci.openshift.io: "true".This is the first of several compositional, domain-specific presets — each covers one logical domain with its own label, and they compose independently.
Rollout
make updaterun — regenerates all jobs, removing ~888K lines of boilerplate and adding the label.🤖 Generated with Claude Code