Skip to content

ci-tools: use bin instead of test-bin for non-test jobs#75851

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
joepvd:ci-tools-drop-race-from-non-test-jobs
Mar 10, 2026
Merged

ci-tools: use bin instead of test-bin for non-test jobs#75851
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
joepvd:ci-tools-drop-race-from-non-test-jobs

Conversation

@joepvd
Copy link
Copy Markdown
Contributor

@joepvd joepvd commented Mar 7, 2026

Summary

  • Switch integration, breaking-changes, checkconfig, and frontend-checks jobs from from: test-bin to from: bin in the ci-operator config for openshift/ci-tools.
  • These jobs only run CLI tools for deterministic operations on local files and do not benefit from race-instrumented binaries. Using test-bin triggers make race-install (~28 min), adding an unnecessary expensive compilation step.
  • With from: bin, these jobs reuse the production binaries already built by the images job (make production-install), leveraging ci-operator's namespace-level image caching to skip compilation entirely when the bin image already exists.
  • Increases compute and memory resources of unit job, as the compilation and run of go -race is memory and cpu intensive.

Impact

Expected CI time savings of ~28 minutes per affected job invocation (4 jobs), as each no longer needs to independently compile all binaries with -race. Expected speed up of unit job.

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor
@openshift-ci openshift-ci bot requested review from hector-vido and smg247 March 7, 2026 09:24
The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor
@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse pull-ci-openshift-ci-tools-main-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse pull-ci-openshift-ci-tools-main-frontend-checks

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse pull-ci-openshift-ci-tools-main-e2e-oo

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse pull-ci-openshift-ci-tools-main-breaking-changes pull-ci-openshift-ci-tools-main-e2e pull-ci-openshift-ci-tools-main-e2e-oo

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor
@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse pull-ci-openshift-ci-tools-main-frontend-checks

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse pull-ci-openshift-ci-tools-main-integration pull-ci-openshift-ci-tools-main-checkconfig

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse pull-ci-openshift-ci-tools-main-frontend-checks

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@joepvd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ci-tools-main-breaking-changes openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-checkconfig openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-codegen openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e-oo openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-format openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-frontend-checks openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-images openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-integration openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-lint openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-security openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-unit openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-vendor openshift/ci-tools presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 7, 2026

/pj-rehearse pull-ci-openshift-ci-tools-main-integration pull-ci-openshift-ci-tools-main-checkconfig pull-ci-openshift-ci-tools-main-breaking-changes pull-ci-openshift-ci-tools-main-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 7, 2026

@joepvd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/ci-tools/main/breaking-changes 2d97b16 link unknown /pj-rehearse pull-ci-openshift-ci-tools-main-breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joepvd
Copy link
Copy Markdown
Contributor Author

joepvd commented Mar 9, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 9, 2026
@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 94252fc into openshift:main Mar 10, 2026
17 of 18 checks passed
mpkredhat pushed a commit to mpkredhat/release that referenced this pull request Mar 11, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Mar 11, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
ibm-adarsh pushed a commit to ibm-adarsh/release that referenced this pull request Mar 12, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
amp-rh pushed a commit to amp-rh/openshift-release that referenced this pull request Mar 12, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
tareqalayan pushed a commit to tareqalayan/release that referenced this pull request Mar 13, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
qiliRedHat pushed a commit to qiliRedHat/release that referenced this pull request Mar 13, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
MayXuQQ pushed a commit to MayXuQQ/release that referenced this pull request Mar 17, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Mar 17, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
sairameshv pushed a commit to sairameshv/release that referenced this pull request Mar 23, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
zhouying7780 pushed a commit to zhouying7780/release that referenced this pull request Mar 25, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
rrasouli pushed a commit to rrasouli/release that referenced this pull request Mar 25, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
anpingli pushed a commit to anpingli/release that referenced this pull request Mar 30, 2026
)

* ci-tools: use bin instead of test-bin for non-test jobs

The integration, breaking-changes, checkconfig, and frontend-checks
jobs were using `from: test-bin`, which triggers `make race-install`
(~28 min) to compile all binaries with the race detector. These jobs
only run CLI tools for deterministic operations on local files and
do not benefit from race instrumentation.

Switch them to `from: bin` so they reuse the production binaries
already built by the images job via `make production-install`,
avoiding a redundant expensive compilation step.

Made-with: Cursor

* ci-tools: bump unit test resources for race detector

The unit test runs `go test -race -count=25 ./...` which needs
significantly more memory and CPU than the 1Gi/1CPU default.
Race-instrumented tests typically use 5-10x more memory.

Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow
better parallelism.

Made-with: Cursor

* ci-tools: use src for frontend-checks instead of bin

The bin image removes frontend/dist/dummy files during
make production-install, causing verify-frontend-format to
detect a git diff and fail. frontend-checks only runs npm/prettier
checks and does not need compiled Go binaries.

Made-with: Cursor

* ci-tools: restore dummy files before frontend-checks on bin image

The bin image removes frontend/dist/dummy files during
make production-install. Restore them before running
verify-frontend-format to prevent a spurious git diff failure.
This lets frontend-checks use from: bin (with pre-built
node_modules) instead of from: src (which requires a slow
npm ci install).

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants