ci-tools: use bin instead of test-bin for non-test jobs#75851
Conversation
The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor
The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor
|
/pj-rehearse |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-ci-tools-main-unit |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-ci-tools-main-frontend-checks |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-ci-tools-main-e2e-oo |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-ci-tools-main-breaking-changes pull-ci-openshift-ci-tools-main-e2e pull-ci-openshift-ci-tools-main-e2e-oo |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor
|
/pj-rehearse pull-ci-openshift-ci-tools-main-frontend-checks |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-ci-tools-main-integration pull-ci-openshift-ci-tools-main-checkconfig |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
|
/pj-rehearse pull-ci-openshift-ci-tools-main-frontend-checks |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-ci-tools-main-integration pull-ci-openshift-ci-tools-main-checkconfig pull-ci-openshift-ci-tools-main-breaking-changes pull-ci-openshift-ci-tools-main-unit |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@joepvd: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
94252fc
into
openshift:main
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
) * ci-tools: use bin instead of test-bin for non-test jobs The integration, breaking-changes, checkconfig, and frontend-checks jobs were using `from: test-bin`, which triggers `make race-install` (~28 min) to compile all binaries with the race detector. These jobs only run CLI tools for deterministic operations on local files and do not benefit from race instrumentation. Switch them to `from: bin` so they reuse the production binaries already built by the images job via `make production-install`, avoiding a redundant expensive compilation step. Made-with: Cursor * ci-tools: bump unit test resources for race detector The unit test runs `go test -race -count=25 ./...` which needs significantly more memory and CPU than the 1Gi/1CPU default. Race-instrumented tests typically use 5-10x more memory. Bump to 4Gi memory and 4 CPU to reduce GC pressure and allow better parallelism. Made-with: Cursor * ci-tools: use src for frontend-checks instead of bin The bin image removes frontend/dist/dummy files during make production-install, causing verify-frontend-format to detect a git diff and fail. frontend-checks only runs npm/prettier checks and does not need compiled Go binaries. Made-with: Cursor * ci-tools: restore dummy files before frontend-checks on bin image The bin image removes frontend/dist/dummy files during make production-install. Restore them before running verify-frontend-format to prevent a spurious git diff failure. This lets frontend-checks use from: bin (with pre-built node_modules) instead of from: src (which requires a slow npm ci install). Made-with: Cursor
Summary
integration,breaking-changes,checkconfig, andfrontend-checksjobs fromfrom: test-bintofrom: binin the ci-operator config foropenshift/ci-tools.test-bintriggersmake race-install(~28 min), adding an unnecessary expensive compilation step.from: bin, these jobs reuse the production binaries already built by theimagesjob (make production-install), leveraging ci-operator's namespace-level image caching to skip compilation entirely when thebinimage already exists.unitjob, as the compilation and run ofgo -raceis memory and cpu intensive.Impact
Expected CI time savings of ~28 minutes per affected job invocation (4 jobs), as each no longer needs to independently compile all binaries with
-race. Expected speed up ofunitjob.