Skip to content

[do-not-merge] serverless operator periodic upgrade tests#78849

Closed
simkam wants to merge 1 commit into
openshift:mainfrom
simkam:s-o-olmv1-upgrade
Closed

[do-not-merge] serverless operator periodic upgrade tests#78849
simkam wants to merge 1 commit into
openshift:mainfrom
simkam:s-o-olmv1-upgrade

Conversation

@simkam
Copy link
Copy Markdown
Contributor

@simkam simkam commented May 5, 2026

test only, rehearsing openshift-knative/hack#966

Summary by CodeRabbit

  • Tests
    • Added weekly automated testing for Knative Serverless operator upgrades using OLM v1 on OpenShift 4.21-techpreview. The new upgrade test mirrors existing end-to-end settings and validates upgrade paths with the same operator dependencies and resource configurations to ensure upgrade reliability and compatibility.

@simkam
Copy link
Copy Markdown
Contributor Author

simkam commented May 5, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Walkthrough

Adds a scheduled Prow test job olmv1-operator-upgrade to the 4.21-techpreview ci-operator config, registers the job with the Slack reporter, and wires it to the existing openshift-e2e-aws workflow to run make test-upgrade for OLM v1 on a weekly cron.

Changes

OLM v1 Operator Upgrade Test Job

Layer / File(s) Summary
Job Registration
ci-operator/config/openshift-knative/serverless-operator/.config.prowgen
Added olmv1-operator-upgrade to slack_reporter.job_names.
Job Configuration (Data/Spec)
ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__4.21-techpreview.yaml
New tests entry as: olmv1-operator-upgrade inserted with cron 45 7 * * 0, env/profile matching olmv1-operator-e2e, command make test-upgrade (OLM_VERSION=v1), and same image dependency list.
Job Wiring / Execution
...openshift-knative-serverless-operator-main__4.21-techpreview.yaml
Job configured to run via the existing openshift-e2e-aws workflow with identical resource requests/limits to the e2e job.
Tests / Docs / Manifests
NONE
No test files or additional docs changed in this PR.
sequenceDiagram
    participant Prow as Prow Scheduler
    participant CI as ci-operator Job
    participant AWS as AWS Cluster
    participant Slack as Slack Reporter

    Prow->>CI: trigger scheduled job olmv1-operator-upgrade (cron)
    CI->>CI: checkout code, prepare images, set OLM_VERSION=v1
    CI->>AWS: run openshift-e2e-aws workflow (make test-upgrade)
    AWS-->>CI: return test results
    CI->>Slack: report job success/failure (slack_reporter)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding periodic upgrade tests for the serverless operator related to OLM v1, which matches the actual changes of adding olmv1-operator-upgrade job configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only CI configuration files, not Go test code. The custom check for Ginkgo test names is not applicable since no test code was changed.
Test Structure And Quality ✅ Passed The Ginkgo test code quality check is not applicable. The PR modifies only CI-operator configuration files, not actual test code files.
Microshift Test Compatibility ✅ Passed This PR adds CI job configuration (YAML files) for the serverless-operator project, not Ginkgo test code. The check applies to test implementations, not CI configuration files.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies CI-operator configuration files only. No Ginkgo e2e test code (It(), Describe(), etc.) is added. The check applies only to new Ginkgo test definitions, not CI configuration.
Topology-Aware Scheduling Compatibility ✅ Passed The PR modifies only CI/CD configuration files, not deployment manifests, operator code, or controllers. The check targets scheduling constraints in deployed resources, which are absent here.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI config files (YAML, .prowgen). OTE Stdout Contract check applies to Go test code, not configuration. No test binaries modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only CI configuration files (.config.prowgen and YAML). No Ginkgo test code (It(), Describe(), etc.) is present. Check applies to new test code, which is not here.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Kaustubh-pande and aliok May 5, 2026 15:26
@simkam simkam force-pushed the s-o-olmv1-upgrade branch from f068308 to 9072892 Compare May 6, 2026 09:23
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simkam
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@simkam: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-knative-serverless-operator-main-4.21-techpreview-olmv1-operator-upgrade N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@simkam
Copy link
Copy Markdown
Contributor Author

simkam commented May 6, 2026

/pj-rehearse periodic-ci-openshift-knative-serverless-operator-main-4.21-techpreview-olmv1-operator-upgrade

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@simkam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@simkam
Copy link
Copy Markdown
Contributor Author

simkam commented May 6, 2026

/test core-valid

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@simkam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simkam simkam closed this May 6, 2026
@simkam simkam deleted the s-o-olmv1-upgrade branch May 6, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant