AGENT-1429: Add new jobs for ISO No Registry#78986
AGENT-1429: Add new jobs for ISO No Registry#78986pawanpinjarkar wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pawanpinjarkar: This pull request references AGENT-1429 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @andfasano @sadasu |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdate CI: change an existing agent job cron from 12-hourly to 8-hourly, add two new agent conformance jobs to the 5.0 nightly config, and insert an additional compact-ipv4 validation step into the agent conformance ISO-no-registry workflow. ChangesAgent CI: workflow + nightly job updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
/depends on openshift-metal3/dev-scripts#1884 |
pawanpinjarkar
force-pushed
the
additional-jobs-for-no-registry-cluster-install
branch
from
7ca34ac to
2844004
Compare
|
/pj-rehearse |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/hold cancel |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
pawanpinjarkar
force-pushed
the
additional-jobs-for-no-registry-cluster-install
branch
from
2844004 to
bd7eb7b
Compare
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/agent/e2e/generic/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yaml`:
- Line 11: The generic workflow includes a topology/network-specific step ref
"agent-e2e-compact-ipv4-iso-no-registry-validation" which causes non-compact or
non-IPv4 jobs to fail; remove this hard-coded ref from the shared workflow
(agent-e2e-generic-conformance-iso-no-registry-workflow.yaml) and either (a)
move the "agent-e2e-compact-ipv4-iso-no-registry-validation" step into
compact-IPv4-specific jobs/workflows, or (b) replace it with a topology-agnostic
validation step or a conditional/parameterized reference so only compact IPv4
jobs invoke that validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 95ae43f9-e016-49ee-a7e1-2f0334a99b30
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/release/openshift-release-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yamlci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yamlci-operator/step-registry/agent/e2e/generic/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yamlci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
✅ Files skipped from review due to trivial changes (1)
- ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
🚧 Files skipped from review as they are similar to previous changes (2)
- ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
|
@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
2 similar comments
|
@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview |
|
/pj-rehearse |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview |
|
/pj-rehearse |
|
@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
pawanpinjarkar
force-pushed
the
additional-jobs-for-no-registry-cluster-install
branch
from
bd7eb7b to
d2cf27b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Added 2 new tech preview jobs , e2e-agent-ha5-dualstack-iso-no-registry-techpreview and e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview - Increased job run frequency by lowering cron schedule from 12h to 8h - Use agent-e2e-compact-ipv4-iso-no-registry-validation ref
pawanpinjarkar
force-pushed
the
additional-jobs-for-no-registry-cluster-install
branch
from
d2cf27b to
9e639cc
Compare
|
@pawanpinjarkar, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
e2e-agent-ha5-dualstack-iso-no-registry-techpreview, ande2e-agent-single-node-ipv6-none-iso-no-registry-techpreviewjobsAdds new agent-based nightly CI jobs for ISO no-registry deployments and increases periodic frequency
This PR updates the OpenShift release CI configuration to add two new nightly agent-based test jobs for ISO "no registry" cluster installs and to increase the frequency of existing related periodic jobs. These changes affect the OpenShift release repository's CI definitions (ci-operator job configs and an agent step-registry workflow).
What changed practically
Two new nightly jobs were added to the 5.0 nightly job config:
none, deployed with ISO_NO_REGISTRY.intranetcapability, set TechPreviewNoUpgrade, and are scheduled every 8 hours.Existing periodic schedule changes:
0 */12 * * *) to every 8 hours (0 */8 * * *), increasing validation frequency.Workflow enhancement:
Additional notes