Fixes for config access

[janboll]

Add missing export to the e2e-local script which is the one actually ran during CI tests. Also align the cloud export with other variables (use ARO_HCP_CLOUD)

Summary by CodeRabbit

Updated ARO HCP CI test scripts to provide the configuration variables required by local, upgrade, and persistent test workflows.

• Exported ARO_HCP_CONFIG_FILE and REGION in the local test script.
• Standardized the cloud variable as ARO_HCP_CLOUD with the dev value in local-upgrade and persistent test scripts.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 311e6293-f73b-4563-92c4-5a805e81d5ad

📥 Commits

Reviewing files that changed from the base of the PR and between 1bd7187 and b384a4a.

📒 Files selected for processing (3)

• ci-operator/step-registry/aro-hcp/test/local-upgrade/aro-hcp-test-local-upgrade-commands.sh
• ci-operator/step-registry/aro-hcp/test/local/aro-hcp-test-local-commands.sh
• ci-operator/step-registry/aro-hcp/test/persistent/aro-hcp-test-persistent-commands.sh

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The ARO HCP test scripts now use the development cloud setting and export configuration and region variables for local test execution.

Changes

ARO HCP test environment

Layer / File(s)	Summary
Environment variable wiring ci-operator/step-registry/aro-hcp/test/*/aro-hcp-test-*-commands.sh	Local tests export ARO_HCP_CONFIG_FILE and REGION. Local-upgrade and persistent tests use ARO_HCP_CLOUD="dev" instead of CLOUD="public".

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b384a

The CI test scripts now consistently provide the required configuration, region, and development-cloud environment variables. No current merge-readiness risk is identified.

Suggested reviewers: roivaz

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing configuration access for CI tests. It is concise and related to the added configuration export, although it does not mention the cloud variable rena…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only three ARO HCP shell orchestration scripts. The diff adds or renames environment variables and introduces no Ginkgo declarations or test-title construction. Therefor…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only three shell command scripts, with four environment-variable additions/replacements. The committed diff contains no Ginkgo test code or It/BeforeEach/AfterEach/Event…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only three shell command scripts. The commit adds environment exports and changes CLOUD="public" to ARO_HCP_CLOUD="dev"; it adds no Ginkgo tests, test declarations, …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only three CI shell scripts and adds or renames environment exports. The parent-to-HEAD diff contains no new Ginkgo test declarations such as It(), Describe(), Context()…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only CI shell-script environment variables. The verified diff adds ARO_HCP_CONFIG_FILE and REGION, and renames cloud environment variables. It does not add or modify…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only three shell step scripts. The diff adds environment exports and changes CLOUD to ARO_HCP_CLOUD; it does not modify an OTE binary, main(), suite setup, logging…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR changes only three shell harness scripts. The exact diff adds or renames environment variables and does not add Ginkgo test declarations or test code. It introduces no hardcoded IPv4 valu…
No-Weak-Crypto	✅ Passed	The pull request changes only CI environment variables. The recorded diff adds ARO_HCP_CONFIG_FILE and REGION, and replaces CLOUD="public" with ARO_HCP_CLOUD="dev". None uses MD5, SHA1, DES, R…
Container-Privileges	✅ Passed	PASS. The pull request changes only environment-variable exports in three Bash test scripts: ARO_HCP_CONFIG_FILE, REGION, and ARO_HCP_CLOUD. The diff introduces no container or Kubernetes manife…
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive logging was introduced. The diff only adds or changes environment variables: the literal config path, the literal cloud value, and LOCATION copied to REGION. None is a password, token, AP…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@janboll: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-Azure-ARO-HCP-main-e2e-parallel	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-e2e-parallel-inplace-upgrade	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-stable	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-fast	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-nightly	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-stable	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-fast	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-nightly	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-stable	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-fast	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-nightly	Azure/ARO-HCP	presubmit	Registry content changed
pull-ci-openshift-hypershift-main-e2e-aro-hcp	openshift/hypershift	presubmit	Registry content changed
pull-ci-openshift-hypershift-release-5.2-e2e-aro-hcp	openshift/hypershift	presubmit	Registry content changed
pull-ci-openshift-hypershift-release-5.1-e2e-aro-hcp	openshift/hypershift	presubmit	Registry content changed
pull-ci-openshift-hypershift-release-5.0-e2e-aro-hcp	openshift/hypershift	presubmit	Registry content changed
pull-ci-openshift-hypershift-release-5.0-4-23-e2e-aro-hcp	openshift/hypershift	presubmit	Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-slow	N/A	periodic	Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aro-hcp	N/A	periodic	Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel	N/A	periodic	Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel-slow	N/A	periodic	Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel	N/A	periodic	Registry content changed

A total of 28 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[janboll]

/pj-rehearse pull-ci-Azure-ARO-HCP-main-e2e-parallel

[openshift-merge-bot]

@janboll: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[janboll]

/retest-required

[janboll]

/pj-rehearse pull-ci-Azure-ARO-HCP-main-e2e-parallel

[openshift-merge-bot]

@janboll: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[janboll]

/pj-rehearse pull-ci-Azure-ARO-HCP-main-e2e-parallel

[openshift-merge-bot]

@janboll: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[janboll]

/pj-rehearse pull-ci-Azure-ARO-HCP-main-e2e-parallel

[openshift-merge-bot]

@janboll: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@janboll: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/Azure/ARO-HCP/main/e2e-parallel	b384a4a	link	unknown	/pj-rehearse pull-ci-Azure-ARO-HCP-main-e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[janboll]

/pj-rehearse ack
flaky e2e errors, not related to the change done here

[openshift-merge-bot]

@janboll: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[janboll]

/pj-rehearse abort

[openshift-merge-bot]

@janboll: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mmazur]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janboll, mmazur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/aro-hcp/test/local/OWNERS [janboll,mmazur]
• ci-operator/step-registry/aro-hcp/test/local-upgrade/OWNERS [janboll,mmazur]
• ci-operator/step-registry/aro-hcp/test/persistent/OWNERS [janboll,mmazur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment