AGENT-1591: Add support for cluster-managed networking by mhanss · Pull Request #84702 · openshift/release

mhanss · 2026-09-07T12:27:49Z

Summary by CodeRabbit

Adds cluster-managed networking support to the OVE Assisted UI workflow.
Reads API_IP and INGRESS_IP from vips.yaml for cluster-managed networking.
Preserves USER_MANAGED_NETWORKING=true for user-managed networking.
Defaults the workflow to cluster-managed networking.
Applies the default to OVE bare-metal jobs for releases 4.21, 4.22, 5.0, and 5.1.

coderabbitai · 2026-09-07T12:28:51Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 67bfc08d-3fae-433a-934f-7a7e70b4f7d2

📥 Commits

Reviewing files that changed from the base of the PR and between 9f69ee6 and 076e723.

📒 Files selected for processing (6)

ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.21__amd64-nightly.yaml
ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.22__amd64-nightly.yaml
ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-5.0__amd64-nightly.yaml
ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-5.1__amd64-nightly.yaml
ci-operator/step-registry/agent-qe/baremetal/install/ove/disconnected/assisted-ui/agent-qe-baremetal-install-ove-disconnected-assisted-ui-commands.sh
ci-operator/step-registry/agent-qe/baremetal/install/ove/disconnected/assisted-ui/agent-qe-baremetal-install-ove-disconnected-assisted-ui-ref.yaml

💤 Files with no reviewable changes (4)

ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-5.0__amd64-nightly.yaml
ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.22__amd64-nightly.yaml
ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-5.1__amd64-nightly.yaml
ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.21__amd64-nightly.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

ci-operator/step-registry/agent-qe/baremetal/install/ove/disconnected/assisted-ui/agent-qe-baremetal-install-ove-disconnected-assisted-ui-ref.yaml
ci-operator/step-registry/agent-qe/baremetal/install/ove/disconnected/assisted-ui/agent-qe-baremetal-install-ove-disconnected-assisted-ui-commands.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The OVE disconnected bare-metal workflow now defaults to cluster-managed load balancing. It exports VIPs for cluster-managed deployments and enables user-managed networking for other configurations. Nightly jobs no longer set user-managed explicitly.

Changes

OVE networking configuration

Layer / File(s)	Summary
Conditional networking selection `ci-operator/step-registry/agent-qe/baremetal/install/ove/disconnected/assisted-ui/...`	The workflow reference defaults `LOAD_BALANCER_TYPE` to `cluster-managed`. The install script exports `API_IP` and `INGRESS_IP` from `vips.yaml` for cluster-managed networking. Other configurations export `USER_MANAGED_NETWORKING=true`.
Nightly job configuration updates `ci-operator/config/openshift-eng/agent-qe-infra/...`	OVE jobs for releases 4.21, 4.22, 5.0, and 5.1 no longer set `LOAD_BALANCER_TYPE: user-managed`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 076e7

This updates OVE disconnected bare-metal CI to select cluster-managed networking by default while retaining user-managed configuration for other selections. No concrete merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant Workflow as Assisted UI workflow
  participant Script as assisted-ui commands.sh
  participant Vips as vips.yaml
  Workflow->>Script: pass LOAD_BALANCER_TYPE
  Script->>Vips: read VIPs when cluster-managed
  Vips-->>Script: api_vip and ingress_vip
  Script-->>Workflow: export API_IP and INGRESS_IP
  Script-->>Workflow: export USER_MANAGED_NETWORKING for other types

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes CI YAML and an Assisted UI shell workflow. The diff adds no Ginkgo test declarations or titles. Searches of all changed files found no `It()`, `Describe()`, `Context()`,…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only six YAML and shell files. The diff contains no Go test files or Ginkgo constructs such as It, BeforeEach, AfterEach, Eventually, or Consistently. Therefore, the Gin…
Microshift Test Compatibility	✅ Passed	PASS — The pull request adds no Ginkgo e2e tests. The diff changes only four YAML job configurations, one shell workflow script, and one workflow reference. Added lines configure `LOAD_BALANCER_TYPE`,…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS. The pull request changes six CI configuration/step files only: YAML job settings and one shell workflow. The exact diff adds no Ginkgo test declarations and no SNO-sensitive test logic. Therefor…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — the pull request does not add or modify deployment manifests, operator code, or controllers. The verified diff changes only CI environment YAML and an Assisted UI shell/ref workflow: it removes…
Ote Binary Stdout Contract	✅ Passed	The pull request changes only CI YAML and a shell step. The added shell lines assign values from `yq` through command substitution and export variables; they do not write to stdout. The added-line sca…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS. The pull request changes only four CI YAML files and one shell workflow plus its reference YAML. The committed diff adds no Go, JavaScript, or TypeScript test files and adds no Ginkgo declaratio…
No-Weak-Crypto	✅ Passed	The pull-request diff adds only load-balancer branching, VIP extraction, environment variables, and YAML configuration changes. Added lines contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto …
Container-Privileges	✅ Passed	No custom-check failure was introduced. The pull-request diff only removes `LOAD_BALANCER_TYPE: user-managed`, adds networking environment handling, and sets a default variable. No changed file adds `…
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive-data logging was introduced. The changed script reads `api_vip` and `ingress_vip` into `API_IP` and `INGRESS_IP` and exports them, but does not print them or enable shell tracing. The add…
Title check	✅ Passed	The title clearly and concisely describes the main change: adding support for cluster-managed networking in the OVE bare-metal workflows.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

mhanss · 2026-09-07T12:31:43Z

/pj-rehearse periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60

openshift-merge-bot · 2026-09-07T12:31:46Z

@mhanss: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

mhanss · 2026-09-07T14:15:55Z

/pj-rehearse periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60

openshift-merge-bot · 2026-09-07T14:15:57Z

@mhanss: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

mhanss · 2026-09-07T14:39:12Z

/pj-rehearse periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60

coderabbitai · 2026-09-07T14:39:14Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

openshift-merge-bot · 2026-09-07T14:39:54Z

@mhanss: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

coderabbitai · 2026-09-08T07:21:49Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

bmanzari · 2026-09-08T07:22:44Z

/lgtm

coderabbitai · 2026-09-08T08:02:10Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

openshift-ci-robot · 2026-09-08T08:02:24Z

@mhanss: This pull request references AGENT-1591 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

Adds cluster-managed and user-managed networking support to the OVE Assisted UI CI workflow.

Uses API_IP and INGRESS_IP from vips.yaml for cluster-managed networking.

Sets USER_MANAGED_NETWORKING=true for user-managed networking.

Defaults the workflow to cluster-managed networking.

Removes the LOAD_BALANCER_TYPE: user-managed override from the OVE 4.22 bare-metal job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-09-08T08:05:04Z

[REHEARSALNOTIFIER]
@mhanss: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-ove-compact-konflux	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-disc-konflux	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-5.1-amd64-nightly-baremetal-ove-compact-konflux	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-5.0-amd64-nightly-baremetal-ove-compact-konflux	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-5.1-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-5.1-amd64-nightly-baremetal-ove-compact-disc-konflux	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-ove-compact	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-konflux	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-5.0-amd64-nightly-baremetal-ove-compact-disc-konflux	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-5.0-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-ove-compact-disc-konflux	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

mhanss · 2026-09-08T08:19:04Z

/pj-rehearse ack

openshift-merge-bot · 2026-09-08T08:19:07Z

@mhanss: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bmanzari · 2026-09-08T08:36:05Z

/lgtm

openshift-ci · 2026-09-08T08:36:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmanzari, mhanss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift-eng/agent-qe-infra/OWNERS~~ [bmanzari,mhanss]
~~ci-operator/step-registry/agent-qe/baremetal/install/ove/disconnected/assisted-ui/OWNERS~~ [mhanss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-09-08T08:51:49Z

@mhanss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60	`330b0f9`	link	unknown	`/pj-rehearse periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-ove-compact-agent-ipv4-disc-f60`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2026

openshift-ci Bot requested review from bmanzari and pamoedom September 7, 2026 12:28

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2026

mhanss force-pushed the add-cmn-condition branch from 911c899 to 330b0f9 Compare September 7, 2026 14:39

mhanss force-pushed the add-cmn-condition branch from 330b0f9 to 82a8f7a Compare September 8, 2026 07:21

mhanss changed the title ~~WIP: OVE Add support for cluster-managed and user-managed networking~~ OVE: Add support for cluster-managed networking Sep 8, 2026

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2026

openshift-ci Bot assigned bmanzari Sep 8, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2026

Add support for cluster-managed networking

076e723

mhanss force-pushed the add-cmn-condition branch from 82a8f7a to 076e723 Compare September 8, 2026 08:01

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2026

mhanss changed the title ~~OVE: Add support for cluster-managed networking~~ AGENT-1591: Add support for cluster-managed networking Sep 8, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 8, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2026

openshift-merge-bot Bot merged commit 19d3b56 into openshift:main Sep 8, 2026
16 checks passed

Uh oh!

Conversation

mhanss commented Sep 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

mhanss commented Sep 7, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 7, 2026

Uh oh!

mhanss commented Sep 7, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 7, 2026

Uh oh!

mhanss commented Sep 7, 2026

Uh oh!

coderabbitai Bot commented Sep 7, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 7, 2026

Uh oh!

coderabbitai Bot commented Sep 8, 2026

Uh oh!

bmanzari commented Sep 8, 2026

Uh oh!

coderabbitai Bot commented Sep 8, 2026

Uh oh!

openshift-ci-robot commented Sep 8, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Sep 8, 2026

Uh oh!

mhanss commented Sep 8, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 8, 2026

Uh oh!

bmanzari commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mhanss commented Sep 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading

openshift-ci-robot commented Sep 8, 2026 •

edited by atlassian Bot

Loading