Skip to content

[DO NOT MERGE] Rerun nightly jobs 4.16.70 - #84708

Open
rh-akhatavk wants to merge 1 commit into
openshift:mainfrom
rh-akhatavk:4.16.70-nightly-rerun
Open

[DO NOT MERGE] Rerun nightly jobs 4.16.70#84708
rh-akhatavk wants to merge 1 commit into
openshift:mainfrom
rh-akhatavk:4.16.70-nightly-rerun

Conversation

@rh-akhatavk

@rh-akhatavk rh-akhatavk commented Sep 7, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Renames two Azure test job identifiers in the OpenShift tests private 4.16 AMD64 nightly CI configuration.
  • The changes affect azure-ipi-marketplace-mini-perm-f14 and azure-stack-upi-f28-destructive.
  • The new identifiers append -test to each job name.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 1a8796f5-e9c1-474c-b0ba-6f58dce8255f

📥 Commits

Reviewing files that changed from the base of the PR and between 92fdb03 and ccefc0d.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16__amd64-nightly.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

Two Azure test job identifiers were renamed to add the -test suffix. Their schedules, environments, clusters, test chains, and workflows remain unchanged.

Changes

Azure job identifier updates

Layer / File(s) Summary
Rename Azure test jobs
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16__amd64-nightly.yaml
The Azure marketplace minimal-permissions and Azure Stack UPI destructive jobs now use identifiers ending in -test.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ccefc

This updates two Azure test job names to use the -test suffix without changing their execution configuration. No merge-blocking risk is identified from the supplied change details.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the pull request intent to rerun the 4.16.70 nightly jobs, which matches the affected nightly test configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only CI job identifiers and generated Prow job targets in two YAML files. The changed fields are as: ..., job name, and --target, not Ginkgo It(), Describe(), `Conte…
Test Structure And Quality ✅ Passed PASS: The pull request changes only two Azure job identifiers in YAML and updates the matching generated periodic-job targets. The commit contains no Ginkgo test code, test assertions, setup or cleanu…
Microshift Test Compatibility ✅ Passed PASS — The pull request changes only two YAML job identifiers and their generated Prow job targets. The exact diff contains no Go files, Ginkgo test declarations, API references, or MicroShift-specifi…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo tests and changes no test implementation. The commit only renames two Azure job identifiers in generated YAML and updates their generated Prow job targets. Theref…
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The pull request changes only two CI configuration entries and their generated Prow job names/--target values. The diff does not add or modify deployment manifests, operator code, controllers,…
Ote Binary Stdout Contract ✅ Passed The pull request changes only two YAML configuration files. It renames two test targets and matching generated Prow job names and arguments. It changes no OTE source code and introduces no process-lev…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only two Azure job identifiers and their generated periodic-job names and targets. It adds no Ginkgo tests, IPv4 handling, URLs, image pulls, or external connectivity. T…
No-Weak-Crypto ✅ Passed PASS: The pull request changes only two Azure test-job identifiers and their generated job names/targets. The exact HEAD patch adds no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secre…
Container-Privileges ✅ Passed PASS. The pull-request diff changes only two job identifiers and their matching generated --target values. No added line introduces privileged: true, hostPID, hostNetwork, hostIPC, `SYS_ADMI…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull-request diff changes only two Azure job identifiers and the matching generated Prow job names and targets. The changed lines contain no logging, passwords, tokens, API keys, PII, sessio…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-akhatavk
Once this PR has been reviewed and has the lgtm label, please assign jechen0648 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from jadhaj and sgoveas September 7, 2026 13:43
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rh-akhatavk: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-azure-ipi-marketplace-mini-perm-f14-test N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-azure-stack-upi-f28-destructive-test N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rh-akhatavk

Copy link
Copy Markdown
Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rh-akhatavk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@MrSanketkumar

Copy link
Copy Markdown
Contributor

/retest-required

@MrSanketkumar

Copy link
Copy Markdown
Contributor

/retest

@MrSanketkumar

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@MrSanketkumar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@rh-akhatavk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-azure-ipi-marketplace-mini-perm-f14-test ccefc0d link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-azure-ipi-marketplace-mini-perm-f14-test
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-azure-stack-upi-f28-destructive-test ccefc0d link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-azure-stack-upi-f28-destructive-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants