Skip to content

RHOSDT-3.11: point disconnected job at 3.11 index images - #84710

Open
rubenvp8510 wants to merge 5 commits into
openshift:mainfrom
rubenvp8510:rhosdt-3.11-disconnected-indices
Open

RHOSDT-3.11: point disconnected job at 3.11 index images#84710
rubenvp8510 wants to merge 5 commits into
openshift:mainfrom
rubenvp8510:rhosdt-3.11-disconnected-indices

Conversation

@rubenvp8510

@rubenvp8510 rubenvp8510 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

What

Point the OCP 4.16 disconnected job at the RHOSDT 3.11 index images. It still referenced the 3.10 ones set in #80345.

Before (3.10) After (3.11)
OTEL brew…/iib:1155560 brew…/iib:1201675
Tempo brew…/iib:1157120 quay…/tempo-fbc-v4-16@sha256:c7f7e5b0

Why the Tempo one is an FBC and not an IIB

The brew IIB currently available for Tempo 3.11 (iib:1201014) still contains the August build — operator 71d3e6e8, jaeger-query a2065cb5. The 3.11.0 release payload ships the September build (bundle 4ae2a2bd, operator a5c643f7, jaeger-query 5c191da5), and the Konflux FBC for OCP 4.16 from that payload is the only index I could find that carries it. Both catalogs were extracted and the digests verified against release-payloads/tempo-stage-3.11.0.yaml and otel-stage-3.11.yaml.

If a brew IIB containing the September build becomes available, swapping it in would be preferable for consistency with the other jobs.

Note

This does not fix the current failure of this job. It dies earlier, in enable-qe-catalogsource-disconnected, pulling aosqe-index:v1.29 from the mirror registry:

reading manifest v1.29 in <mirror-registry>:6001/openshift-qe-optional-operators/aosqe-index:
manifest unknown

That step runs before these index images are used. The last green run of this job was the rehearsal of #80345 back in June; every periodic run since has failed. This PR only stops the job from testing 3.10 content once that is unblocked.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates the disconnected OpenShift 4.16 distributed-tracing CI job for the openshift/distributed-tracing-qe repository.
  • Updates the OTEL catalog to Brew IIB 1201675.
  • Updates the Tempo catalog to the RHOSDT 3.11 Konflux FBC image.
  • Disables default OperatorHub sources before creating the Tempo and OTEL catalog sources.
  • Skips the unavailable QE catalog source and removes the unused amq-streams operator.

The OCP 4.16 disconnected job still referenced the RHOSDT 3.10 index
images. Update both to the 3.11 builds:

- OTEL: brew iib:1201675 (collector 7763adf1, snapshot
  otel-main-20260825-143143-000)
- Tempo: the Konflux FBC for OCP 4.16 from the 3.11.0 release payload,
  which carries bundle 4ae2a2bd / operator a5c643f7 — the September
  build. The brew IIB currently available for Tempo (iib:1201014) still
  contains the August build, so it would not exercise the release
  candidate.

Both digests were verified by extracting the catalogs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWrVkBmYnGwnuSfaK6d1cK
@rubenvp8510

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-distributed-tracing-qe-main-ocp-4.16-disconnected-distributed-tracing-tests-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rubenvp8510: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 313f4236-a21c-490d-9c9a-a8564f2da370

📥 Commits

Reviewing files that changed from the base of the PR and between 406de4c and 6eafdba.

📒 Files selected for processing (1)
  • ci-operator/step-registry/distributed-tracing/install/disconnected/distributed-tracing-install-disconnected-commands.sh

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The disconnected OpenShift 4.16 environment updates OTEL and Tempo image references, removes obsolete operator settings, skips the QE application registry, and disables default catalog sources before catalog mirroring.

Changes

Disconnected tracing setup

Layer / File(s) Summary
Update disconnected environment configuration
ci-operator/config/openshift/distributed-tracing-qe/openshift-distributed-tracing-qe-main__ocp-4.16-disconnected.yaml
The configuration updates the OTEL and Tempo IIB image references, removes OO_INDEX and amq-streams, and adds SKIP_QE_APP_REGISTRY: "true".
Disable default catalog sources before mirroring
ci-operator/step-registry/distributed-tracing/install/disconnected/distributed-tracing-install-disconnected-commands.sh
The script patches operatorhub cluster to set disableAllDefaultSources: true and runs this step after check_marketplace and before mirror_catalog_icsp.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 6eafd

This change disables default OperatorHub sources before disconnected catalog mirroring to avoid unreachable sources and duplicate package manifests. No concrete current-head merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the disconnected job to use RHOSDT 3.11 index images.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes only one disconnected-job YAML file and one installation shell script. The YAML changes image references, operator configuration, and SKIP_QE_APP_REGISTRY; the shell c…
Test Structure And Quality ✅ Passed PASS: The pull request changes only CI YAML, job configuration, and shell workflow code. The diff contains no Ginkgo test files, It blocks, cluster-operation waits, or Ginkgo assertions. Therefore the…
Microshift Test Compatibility ✅ Passed PASS. The complete available PR delta changes only one YAML job configuration and one shell install step. It adds no Go files or Ginkgo declarations such as It, Describe, Context, or When. The Operato…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only one disconnected-job YAML file and one shell install step. The diff adds no Go files and no Ginkgo declarations such as It(), Describe(), Context(), or When(). Ther…
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The pull request changes only a CI environment configuration and a disconnected-install shell step. The configuration updates index image variables, operator entries, and SKIP_QE_APP_REGISTRY
Ote Binary Stdout Contract ✅ Passed PASS. The apparent PR diff changes only one YAML job configuration and one shell install script. It adds shell echo output and an oc patch command; it changes no Go or other OTE binary source, and…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only the disconnected job YAML and its shell install step. The diff adds no Ginkgo tests, test files, or test code. Therefore, the IPv4 and external-connectivity test ch…
No-Weak-Crypto ✅ Passed The pull request adds no MD5, SHA1, DES, RC4, 3DES, Blowfish, or ECB usage. It adds no custom cryptographic implementation or non-constant-time secret comparison. The changed shell code only patches O…
Container-Privileges ✅ Passed No custom-check failure was introduced. The PR changes only index-image references, operator list/env values, and adds an oc patch operatorhub command. The changed YAML has no privileged, host nam…
No-Sensitive-Data-In-Logs ✅ Passed The pull request adds no logging of passwords, tokens, API keys, PII, session IDs, or customer data. The new log messages report only catalog-source status. The added run_command logs a static `oc p…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2026
The Konflux FBC image failed the rehearsal immediately, before the
cluster was provisioned. Every other job in this repo uses
brew.registry.redhat.io for index images, so fall back to that.

Note this IIB (1201014) carries the August Tempo build, not the
September one shipped in the 3.11.0 release payload. Swapping in a brew
IIB built from the September snapshot would be preferable once one is
available.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWrVkBmYnGwnuSfaK6d1cK
@rubenvp8510

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-distributed-tracing-qe-main-ocp-4.16-disconnected-distributed-tracing-tests-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rubenvp8510: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

The step derives the QE optional-operators index tag from the cluster's
Kubernetes version, giving aosqe-index:v1.29 for OCP 4.16. That image is
not present in the mirror registry, so the step fails:

  reading manifest v1.29 in <mirror>/openshift-qe-optional-operators/
  aosqe-index: manifest unknown

This has broken every periodic run of this job; the last green run was
the rehearsal of openshift#80345 in June.

The step accepts an OO_INDEX parameter that bypasses the tag
derivation. In this job the QE index only provides amq-streams — Tempo
and OTEL come from their own catalog sources built from the index images
above — so the released operator index serves the same purpose and is
available.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWrVkBmYnGwnuSfaK6d1cK
@rubenvp8510

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-distributed-tracing-qe-main-ocp-4.16-disconnected-distributed-tracing-tests-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rubenvp8510: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

enable-qe-catalogsource-disconnected derives the QE optional-operators
index tag from the cluster's Kubernetes version, giving
aosqe-index:v1.29 for OCP 4.16. That image is no longer available, so
the copy to the mirror registry produces nothing and the step dies on
ImagePullBackOff. This has broken every periodic run of this job since
June.

The step gained a SKIP_QE_APP_REGISTRY parameter in openshift#83517, and openshift#83518
moved the check to after the mirror ICSP is created, so setting it
leaves the mirror infrastructure in place and only skips the QE
catalogsource. That is a better fit here than pointing OO_INDEX at
another index, since this job does not need the QE catalog at all:
Tempo and OTEL come from cs-tempo and cs-otel, built from the index
images above.

amq-streams was the only operator sourced from the QE catalog, and none
of the five tests in tests/e2e-disconnected use Kafka, so it is dropped
from OPERATORS.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWrVkBmYnGwnuSfaK6d1cK
@rubenvp8510

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-distributed-tracing-qe-main-ocp-4.16-disconnected-distributed-tracing-tests-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rubenvp8510: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

With SKIP_QE_APP_REGISTRY set, enable-qe-catalogsource-disconnected
exits before disable_default_catalogsource, so the default OperatorHub
sources stay enabled. They cannot be reached from a disconnected
cluster, and they leave duplicate packagemanifests behind: the last run
showed three opentelemetry-product packagemanifests, and the
opentelemetry-product subscription never produced an installedCSV,
failing install-operators after 31m.

Disable them here instead, before cs-tempo and cs-otel are created.
This step is only used by the OCP 4.16 disconnected job, so the change
is scoped to it — the shared enable-qe-catalogsource step is used by 17
other configs and is left alone.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWrVkBmYnGwnuSfaK6d1cK
@rubenvp8510

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-distributed-tracing-qe-main-ocp-4.16-disconnected-distributed-tracing-tests-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rubenvp8510: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rubenvp8510

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rubenvp8510: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-distributed-tracing-qe-main-ocp-4.16-disconnected-distributed-tracing-tests-disconnected N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@rubenvp8510: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-distributed-tracing-qe-main-ocp-4.16-disconnected-distributed-tracing-tests-disconnected 6eafdba link unknown /pj-rehearse periodic-ci-openshift-distributed-tracing-qe-main-ocp-4.16-disconnected-distributed-tracing-tests-disconnected

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant