Skip to content

Pruned unused ci-operator-yaml-creator tool references - #84714

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
hector-vido:prune-ci-operator-yaml-creator
Sep 8, 2026
Merged

Pruned unused ci-operator-yaml-creator tool references#84714
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
hector-vido:prune-ci-operator-yaml-creator

Conversation

@hector-vido

@hector-vido hector-vido commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

An effort to accomplish DPTP-3528

Summary by CodeRabbit

  • Removed the unused ci-operator-yaml-creator image from auto-config-brancher.
  • Deleted its standalone image definition from the OpenShift CI tools configuration.
  • This reduces obsolete CI tool references as part of DPTP-3528.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 949e1b22-0825-4425-99fe-47301bf2e761

📥 Commits

Reviewing files that changed from the base of the PR and between 1973691 and 7a8bfb1.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The change removes ci-operator-yaml-creator from auto-config-brancher inputs and deletes its standalone image definition.

Changes

Cohort / File(s) Summary
Image configuration
ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml
Removes the unused image input and standalone image definition.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7a8bf

This change removes unused tool references with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing unused references to the ci-operator-yaml-creator tool.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only one YAML configuration file. The diff removes two ci-operator-yaml-creator image references and adds no Ginkgo test code or test titles. Therefore, it introduces …
Test Structure And Quality ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. It removes image references and does not add or modify Ginkgo tests. Therefore, the listed tes…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only one YAML configuration file and removes 14 lines for the unused ci-operator-yaml-creator image input and image definition. The diff adds no Ginkgo tests or test r…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only one YAML configuration file and removes 14 unused image-reference lines. It adds no Ginkgo e2e tests or test code, so the SNO compatibility conditions do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. It removes one binary input and one standalone image definition for ci-operator-yaml-creator. The …
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only one YAML file. It removes the ci-operator-yaml-creator input from auto-config-brancher and deletes its image definition. No Go or OTE binary source changes exis…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. The diff removes image references and a standalone image definition for `ci-operator-yaml-crea…
No-Weak-Crypto ✅ Passed PASS. The pull request changes one YAML file and only deletes ci-operator-yaml-creator image references and its image definition. The patch adds no cryptographic code, algorithms, modes, custom cryp…
Container-Privileges ✅ Passed The pull request only deletes 14 lines from one ci-operator image configuration. The diff removes a ci-operator-yaml-creator input and image definition. It adds no container or Kubernetes privilege …
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes only one YAML file and removes 14 lines. The exact diff contains no logging statements, log messages, or sensitive data. It removes the ci-operator-yaml-creator image …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@hector-vido: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ci-tools-main-breaking-changes openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-checkconfig openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-codegen openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e-oo openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-format openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-frontend-checks openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-images openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-integration openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-lint openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-security openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-unit openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-prow openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-vendor openshift/ci-tools presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hector-vido

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-ci-tools-main-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@hector-vido: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/ci-tools/main/e2e-oo 7a8bfb1 link unknown /pj-rehearse pull-ci-openshift-ci-tools-main-e2e-oo

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hector-vido

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 7, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2026
@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 572a18a into openshift:main Sep 8, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants