Skip to content

Trigger docs checks on python plugin files changes - #4227

Merged
bshewale merged 2 commits into
openstack-k8s-operators:mainfrom
michburk:spellfix
Oct 6, 2026
Merged

bshewale merged 2 commits into
openstack-k8s-operators:mainfrom
michburk:spellfix

Conversation

@michburk

@michburk michburk commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Files in plugins/modules/**/*.py and plugins/module_utils/**/*.py are used to generate docs, so trigger docs checks on changes to these files.

Also adds entries to the dictionary to resolve some new 'spelling errors' because these files went unchecked in a previous pr.

Some recent additions to the docs were missing entries in the
dictionary.

Signed-off-by: Michael Burke <michburk@redhat.com>
Include plugin sources in the documentation workflow so their
generated docs are built and spellchecked.

Generated-By: GPT-6 Luna <noreply@openai.com>
Signed-off-by: Michael Burke <michburk@redhat.com>
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Run documentation checks when Python plugin sources change

⚙️ Configuration changes 📝 Documentation 🕐 Less than 10 minutes

Grey Divider

AI Description

• Trigger documentation checks when module or module utility Python files change.
• Recognize three generated-documentation terms to prevent spelling check failures.
Diagram

graph TD
  M["Module sources"] --> G{"PR path match"} --> B["Build documentation"] --> S["Check spelling"]
  U["Utility sources"] --> G
  D["Custom dictionary"] --> S
Loading
High-Level Assessment

Extending the existing path filter is the simplest way to cover plugin sources without duplicating documentation jobs or changing the established build and spelling checks.

Files changed (2) +5 / -0

Documentation (1) +3 / -0
en-custom.txtAccept three terms in generated documentation +3/-0

Accept three terms in generated documentation

• Adds clusterimagepolicy, drosenfe, and rosenfeld to the custom spelling dictionary so the documentation check accepts them.

docs/dictionary/en-custom.txt

Other (1) +2 / -0
documentation.ymlTrigger documentation workflow for Python plugin changes +2/-0

Trigger documentation workflow for Python plugin changes

• Adds recursive Python-file path filters for modules and module utilities. Pull requests changing those sources now run the existing documentation build and spelling check.

.github/workflows/documentation.yml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@michburk
michburk force-pushed the spellfix branch 2 times, most recently from d9e0c8d to 5256d63 Compare October 2, 2026 20:18
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/52f21d268410463298112d4dc24bcbe1

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 08s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 20s

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/471c5d8598a44a048a7c2d2739f0ca16

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 39m 31s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 12s
✔️ podified-multinode-edpm-deployment-crc-centos-10 SUCCESS in 1h 22m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 39s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 1h 55m 38s
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 3h 50m 32s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 1h 31m 56s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 43s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 40s

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evallesp

evallesp commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evallesp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Oct 5, 2026

@Valkyrie00 Valkyrie00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bshewale
bshewale merged commit 5353820 into openstack-k8s-operators:main Oct 6, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants