Skip to content

[18.0-fr5] Fix: Added customizable ansibleEE env ConfigMap name#1830

Open
openshift-cherrypick-robot wants to merge 2 commits intoopenstack-k8s-operators:18.0-fr5from
openshift-cherrypick-robot:cherry-pick-1772-to-18.0-fr5
Open

[18.0-fr5] Fix: Added customizable ansibleEE env ConfigMap name#1830
openshift-cherrypick-robot wants to merge 2 commits intoopenstack-k8s-operators:18.0-fr5from
openshift-cherrypick-robot:cherry-pick-1772-to-18.0-fr5

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 26, 2026

This is an automated cherry-pick of #1772

/assign rabi

@oliashish
Fix: added customizable ansibleEE env ConfigMap name
7a2c695 
Currently there is only one hardcoded string `openstack-aee-default-env`
for ansibleEE environment variable, which is applied throughout the
cluser.
This PR tries to let users ability to customize the ansibleEE env
configMap for deployments and nodeset levels individually.
The precedence order for ansibleEEEnvConfigMap is deployment > nodeset >
default.
@oliashish
removed ansibleEEEnvConfigMapName from nodeset level as it willl conf…
7e3e229 
…lict with DeployOnAllNodeSet services
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 26, 2026
Merged
@openshift-ci openshift-ci bot requested review from abays and fultonj February 26, 2026 13:14
@abays
Copy link
Contributor

abays commented Mar 3, 2026

/test openstack-operator-build-deploy-kuttl-4-18

    case.go:380: command "echo \"Checking rotation of non API service certificates...\"\\n NAMES..." exceeded 6 sec timeout, context deadline exceeded
    logger.go:42: 08:47:35 | ctlplane-tls-cert-rotation | skipping kubernetes event logging

/test openstack-operator-build-deploy-kuttl-4-18

abays
abays approved these changes Mar 3, 2026
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, openshift-cherrypick-robot, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl-4-18 7e3e229 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rabi rabi rabi approved these changes

@abays abays abays approved these changes

@fultonj fultonj Awaiting requested review from fultonj

Assignees

@rabi rabi

@abays abays

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @abays @rabi @oliashish