Add infra container images for memcached, redis, rabbitmq and mariadb - #13
Conversation
a729356 to
b0c9ccd
Compare
amoralej
left a comment
amoralej
left a comment
There was a problem hiding this comment.
Please, rebase and include the rpms.in.yaml files created by update-sources for your projects. Also, note my comments about repos. Thanks!
213a7aa to
04bf979
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
979f55e to
e717ae3
Compare
|
I've implemented pure-rpm case in #71 . Note that I'm keeping the build base in project dir instead of image dir for consistency with other service images, i expect it may help to import the content in other build envieronments (as konflux). That will force to update your COPY commands. I'd appreciate if you rebase on that one. |
amoralej
left a comment
amoralej
left a comment
There was a problem hiding this comment.
Please rebase when ready to be merged. See my comments inline. Thanks!
e717ae3 to
dbd5466
Compare
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dbd5466 to
9908fd5
Compare
Port container definitions from tcib for infrastructure services that don't require Python source builds. These are RPM-only containers built on top of openstack-base, following the pure-RPM image convention (build context is the project directory, no sources.txt). - memcached: simple memcached service - redis: uses valkey (Redis-compatible fork) with procps-ng - rabbitmq: installs from CentOS Messaging SIG repo directly (the centos-release-rabbitmq-4 package requires centos-release which is unavailable on UBI) - mariadb: full Galera cluster support with mariadb-server-galera The operators (infra-operator, mariadb-operator) handle all service bootstrapping externally via init containers and ConfigMap-mounted scripts, so no kolla bootstrap logic is included; the Containerfiles just set CMD for the service binary. In the base image rpms.repo, replace the DLRN rabbitmq repo with the CentOS Stream Messaging SIG RabbitMQ 4 repo. Also adds rpms.in.yaml files for the mariadb, memcached, redis and rabbitmq projects, and refreshes the base buildrequirements lockfile (vcs-versioning 2.3.0 -> 2.3.1) so the reproducibility check passes now that the base image is in scope. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d410e7b
into
openstack-k8s-operators:main
4 participants
Port container definitions from tcib for infrastructure services that don't require Python source builds. These are RPM-only containers built on top of openstack-base.
Also updates build.sh to handle infrastructure containers (projects without sources.txt) by skipping source cloning and constraints.