Add telemetry containers - #15
Conversation
|
Some comments:
Special care:
|
8a9a3ed to
2a1bc38
Compare
2a1bc38 to
abee303
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
7016cc6 to
4598511
Compare
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Build failed (check pipeline). Post ❌ s2i-openstack-containers-molecule FAILURE in 1m 47s |
Assisted-By: Cladue Opus 4.6
This makes comparisons between Containerfiles easier.
4598511 to
a7c0f47
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -0,0 +1 @@ | |||
| # No extra system dependencies for central agent | |||
There was a problem hiding this comment.
This command affects to all the containers
bindeps always to at least have:
python3
python3-pip
Also, given that cryptography is pulled as dependency of dependencies, this should also have:
python3-cryptography-43.0.0-4.el10
Also, same for builddeps.txt ( I think i missed it in aodh, btw).
Given that you are having multiple images in the service. You may implement base bindeps.txt for the common part + image bindeps.txt for specific ones.
You can check how it was done in cinder i.e.. The script build.sh supports those two levels for bindeps pythondeps, etc.. and it makes easier to support in multi image. In containerfiles you need to copy both files and cat them in the installation commands.
There was a problem hiding this comment.
How were these building if these were missing? Were they being pulled in as-needed in the regular build.
But this will cause issues in an isolated build
| @@ -0,0 +1,2 @@ | |||
| # Caching backend | |||
| oslo.cache[dogpile] | |||
There was a problem hiding this comment.
For confirmation, ceilometer doesn't access database?
There was a problem hiding this comment.
ceilometer collects metrics and publishes it to external backends.
it doesn't need databases
No description provided.