Skip to content

Add telemetry containers - #15

Open
elfiesmelfie wants to merge 5 commits into
openstack-k8s-operators:mainfrom
elfiesmelfie:add_telemetry_containers
Open

Add telemetry containers#15
elfiesmelfie wants to merge 5 commits into
openstack-k8s-operators:mainfrom
elfiesmelfie:add_telemetry_containers

Conversation

@elfiesmelfie

Copy link
Copy Markdown
Contributor

No description provided.

@amoralej

amoralej commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Some comments:

Special care:

@elfiesmelfie
elfiesmelfie force-pushed the add_telemetry_containers branch 5 times, most recently from 8a9a3ed to 2a1bc38 Compare August 12, 2026 09:18
@elfiesmelfie
elfiesmelfie force-pushed the add_telemetry_containers branch from 2a1bc38 to abee303 Compare August 17, 2026 18:04
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfiesmelfie
elfiesmelfie force-pushed the add_telemetry_containers branch from 7016cc6 to 4598511 Compare August 18, 2026 19:11
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 17194b97-e129-4f7e-a632-5f14dda16866


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/2a9ae396b8cb4290b65fbffbb23b1ffd

s2i-openstack-containers-molecule FAILURE in 1m 47s
s2i-openstack-container-content-provider FAILURE in 2m 51s

@elfiesmelfie
elfiesmelfie force-pushed the add_telemetry_containers branch from 4598511 to a7c0f47 Compare August 18, 2026 21:06
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -0,0 +1 @@
# No extra system dependencies for central agent

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command affects to all the containers

bindeps always to at least have:

python3
python3-pip

Also, given that cryptography is pulled as dependency of dependencies, this should also have:

python3-cryptography-43.0.0-4.el10

Also, same for builddeps.txt ( I think i missed it in aodh, btw).

Given that you are having multiple images in the service. You may implement base bindeps.txt for the common part + image bindeps.txt for specific ones.

You can check how it was done in cinder i.e.. The script build.sh supports those two levels for bindeps pythondeps, etc.. and it makes easier to support in multi image. In containerfiles you need to copy both files and cat them in the installation commands.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were these building if these were missing? Were they being pulled in as-needed in the regular build.
But this will cause issues in an isolated build

@@ -0,0 +1,2 @@
# Caching backend
oslo.cache[dogpile]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For confirmation, ceilometer doesn't access database?

@elfiesmelfie elfiesmelfie Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ceilometer collects metrics and publishes it to external backends.

it doesn't need databases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants