Skip to content

First crack at designate S2I - #77

Merged
openshift-merge-bot[bot] merged 2 commits into
openstack-k8s-operators:mainfrom
beagles:designate-containerfile
Aug 20, 2026
Merged

First crack at designate S2I#77
openshift-merge-bot[bot] merged 2 commits into
openstack-k8s-operators:mainfrom
beagles:designate-containerfile

Conversation

@beagles

@beagles beagles commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@beagles
beagles force-pushed the designate-containerfile branch from 1b3a09a to 0c1588e Compare August 14, 2026 00:41
amoralej
amoralej reviewed Aug 18, 2026
View reviewed changes
Comment thread containers/designate/bindeps.txt Outdated
Comment thread containers/designate/builddeps.txt Outdated
Comment thread containers/designate/designate-backend-bind9/Containerfile
Comment thread containers/designate/unbound/Containerfile
Comment thread containers/designate/designate-central/Containerfile Outdated
Comment thread containers/designate/unbound/Containerfile
@beagles
beagles force-pushed the designate-containerfile branch 2 times, most recently from 15fce9a to 2b1e22a Compare August 18, 2026 19:01
amoralej
amoralej reviewed Aug 19, 2026
View reviewed changes

@amoralej amoralej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Rebasing it on main should fix ci issues.

I'm not sure if you want to keep it as draft for some reason or it's fine to merge.

@beagles
beagles force-pushed the designate-containerfile branch from 2b1e22a to bd787c3 Compare August 19, 2026 12:02
@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a72d9d4d-1c4d-438b-9575-f6a5e755627e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@beagles
beagles force-pushed the designate-containerfile branch 2 times, most recently from a909ff3 to 5f88514 Compare August 19, 2026 12:55
@beagles @claude
First crack at designate S2I
47ad022 
Co-Authored-By: Sonnet 5 <noreply@anthropic.com>
@beagles
beagles force-pushed the designate-containerfile branch from 5f88514 to 47ad022 Compare August 19, 2026 13:31
@beagles
Split out designate worker into separate container file
751ca4e 
Designate worker requires the bind package for rndc commands as well as
rootwrap. Moving it into it's own container file keeps things a bit
tidier.
@beagles
beagles marked this pull request as ready for review August 19, 2026 16:31
amoralej
amoralej approved these changes Aug 20, 2026
View reviewed changes

@amoralej amoralej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openshift-ci openshift-ci Bot added the lgtm label Aug 20, 2026
@rebtoor

rebtoor commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 6cbcc32 into openstack-k8s-operators:main Aug 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoralej amoralej amoralej approved these changes

Assignees

@rebtoor rebtoor

@amoralej amoralej

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beagles @rebtoor @amoralej