Add source-built Horizon dashboard container - #89
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
24cb3c0 to
15cf5f5
Compare
amoralej
left a comment
amoralej
left a comment
There was a problem hiding this comment.
The setup of the repos, dependencies and logic of containerfile looks correct. However, it has very horizon specific content. I'd appreciate review from another horizon maintainer.
It should also have an OWNERS file with the list of owners managing horizon container.
| pyver = "%d.%d" % sys.version_info[:2]; \ | ||
| paths = glob.glob("/usr/lib/python%s/site-packages/*/locale" % pyver); \ | ||
| paths.append("/usr/share/openstack-dashboard/openstack_dashboard/locale"); \ | ||
| [subprocess.run(["django-admin", "compilemessages"], cwd=os.path.dirname(p), check=False) \ | ||
| for p in paths if os.path.isdir(p)]' |
There was a problem hiding this comment.
No problem with this but out of curiosity, wouldn't be easier doing it in bash?
There was a problem hiding this comment.
Hi @amoralej ,
Originally it was generated as bash, but it did not pass the linter check, see: https://github.com/openstack-k8s-operators/s2i-openstack-containers/actions/runs/32065668388/job/95497065045
That is the reason why it was rewritten in Python.
I changed it back and fixed only the linter issue in bash.
15cf5f5 to
8907e4e
Compare
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c3a0cb1 to
45ec60a
Compare
| @@ -0,0 +1,12 @@ | |||
| # See the OWNERS docs at https://www.kubernetes.dev/docs/guide/owners/ | |||
There was a problem hiding this comment.
This is the list of owners in horizon-operator for reference https://github.com/openstack-k8s-operators/horizon-operator/blob/main/OWNERS_ALIASES#L4-L8
user names seems to be very different. These user names seems unknown in the org.
There was a problem hiding this comment.
Thanks, my bad, should be fine now.
|
Please rebase on main |
Package Horizon and the tcib UI plugins as openstack-horizon so it can be build from pinned upstream source. Assisted-By: Cursor Grok 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
45ec60a to
1bc8391
Compare
2 participants
Package Horizon and the tcib UI plugins as openstack-horizon so it can be build from pinned upstream source.
Assisted-By: Cursor Grok 4.6