Fix macOS compatibility for build.sh and tox environments - #95
Open
rebtoor wants to merge 1 commit into
Open
Conversation
Replace the Linux-only nproc call with OS-aware detection using sysctl on Darwin and nproc on Linux. Ensure the pybuild-deps cache directory is created before lockfile generation by using a persistent toxworkdir-based cache path and pre-creating the directory tree in commands_pre. Skip the build tox environment on non-Linux platforms since it requires buildah. Assisted-By: Claude (Anthropic) Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nprocwith OS-aware detection (sysctl -n hw.logicalcpuon Darwin,nprocon Linux)pybuild-depscache directory creation fortox -e update-sourcesandtox -e update-lockfilesby using a persistent{toxworkdir}/cachepath and pre-creating the directory treetox -e buildon non-Linux platforms (requiresbuildah)macOS tox compatibility after this change
lintersupdate-sourcesupdate-lockfilestestbuildTest plan
tox -e linterspasses on macOStox -e testpasses on macOS (44/44 tests)tox -e update-lockfilescompletes on macOStox -e buildcleanly skips on macOS withplatform darwin does not match linuxMade with Cursor