Skip to content

Bundle libxml2 + ICU in the baremetal package so it runs on newer distros (fixes #4362) #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exzile wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bundle libxml2 + ICU in the baremetal package so it runs on newer distros (fixes #4362) #4363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions create_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,23 @@ fi
if [ "$BASE_OS" == "redhat" ] ; then cp -P /usr/lib64/libOpenCL.so* /ovms_release/lib/ ; fi
if [[ "$BASE_OS" =~ "ubuntu" ]] ; then cp -P /usr/lib/x86_64-linux-gnu/libOpenCL.so* /ovms_release/lib/ ; fi

# libxml2 is a runtime dependency of the ovms binary (Dockerfile.ubuntu apt-installs
# it into the runtime image), but it is provided by the base image rather than by
# bazel-out, so the portable tarball never bundled it. The Docker image is therefore
# fine while the baremetal package fails to start on any host whose system libxml2 /
# ICU soname differs from the ubuntu build base -- e.g. Ubuntu 26.04 ships
# libxml2.so.16 + ICU 78, not the libxml2.so.2 + ICU 74 this build links against:
# ovms: error while loading shared libraries: libxml2.so.2: cannot open shared object file
# Bundle libxml2 and its ICU dependency chain (ovms -> libxml2.so.2 -> libicuuc ->
# libicudata) so the tarball is self-contained. The copies land before the patchelf
# rpath pass below, so they get '$ORIGIN/../lib' and resolve one another in the bundle.
# See https://github.com/openvinotoolkit/model_server/issues/4362
if [[ "$BASE_OS" =~ "ubuntu" ]] ; then
cp -P /usr/lib/x86_64-linux-gnu/libxml2.so.2* /ovms_release/lib/
cp -P /usr/lib/x86_64-linux-gnu/libicuuc.so.* /ovms_release/lib/
cp -P /usr/lib/x86_64-linux-gnu/libicudata.so.* /ovms_release/lib/
fi

if [ "$FUZZER_BUILD" == "0" ]; then find /ovms/bazel-bin/src -name 'ovms' -type f -exec cp -v {} /ovms_release/bin \; ; fi;
cd /ovms_release/bin
if [ "$FUZZER_BUILD" == "0" ]; then patchelf --remove-rpath ./ovms && patchelf --set-rpath '$ORIGIN/../lib/' ./ovms; fi;
Expand Down