Skip to content

copy liceneses in RH image - #4412

Merged
dtrawins merged 1 commit into
mainfrom
rh-lic
Jul 27, 2026
Merged

copy liceneses in RH image#4412
dtrawins merged 1 commit into
mainfrom
rh-lic

Conversation

@dtrawins

Copy link
Copy Markdown
Collaborator

🛠 Summary

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Ready to approve

The change is small and targeted, and the only noted issue is a non-blocking image-size optimization opportunity.

Note: this review does not count toward required approvals for merging.

Pull request overview

This PR updates the Red Hat release image build to ensure the runtime container contains license materials under /licenses, aligning with the goal of shipping required licensing artifacts in the final image.

Changes:

  • Replaces COPY --from=pkg /licenses /licenses with an explicit creation of /licenses in the release stage.
  • Copies /ovms/LICENSE and /ovms/thirdparty-licenses into /licenses during the image build.
File summaries
File Description
Dockerfile.redhat Adjusts how license files are populated in the Red Hat release stage image.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Low

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

Comment thread Dockerfile.redhat
Comment on lines +436 to +438
RUN mkdir -p /licenses && \
cp /ovms/LICENSE /licenses/LICENSE && \
cp -r /ovms/thirdparty-licenses /licenses/thirdparty-licenses
@dtrawins
dtrawins merged commit 97d5cc0 into main Jul 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants