Conversation
mzegla
approved these changes
Jul 27, 2026
michalkulakowski
approved these changes
Jul 27, 2026
Contributor
There was a problem hiding this comment.
✅ Ready to approve
The change is small and targeted, and the only noted issue is a non-blocking image-size optimization opportunity.
Note: this review does not count toward required approvals for merging.
Pull request overview
This PR updates the Red Hat release image build to ensure the runtime container contains license materials under /licenses, aligning with the goal of shipping required licensing artifacts in the final image.
Changes:
- Replaces
COPY --from=pkg /licenses /licenseswith an explicit creation of/licensesin thereleasestage. - Copies
/ovms/LICENSEand/ovms/thirdparty-licensesinto/licensesduring the image build.
File summaries
| File | Description |
|---|---|
| Dockerfile.redhat | Adjusts how license files are populated in the Red Hat release stage image. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
Comment on lines
+436
to
+438
| RUN mkdir -p /licenses && \ | ||
| cp /ovms/LICENSE /licenses/LICENSE && \ | ||
| cp -r /ovms/thirdparty-licenses /licenses/thirdparty-licenses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
🧪 Checklist
``