Revert JSXGraph back to version 1.10.1.#1356
Closed
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Closed
Revert JSXGraph back to version 1.10.1.#1356drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Conversation
somiaj
approved these changes
Dec 21, 2025
Contributor
somiaj
left a comment
somiaj
left a comment
There was a problem hiding this comment.
Seems reasonable. I don't think there is anything in the new version we need yet anyways.
Contributor
|
I could just merge this, seems straight forward, but since @Alex-Jordan has been active the last few days, I'll ping them to do it. |
Member
Author
|
I converted this to a draft so that it won't be merged for now. I will submit another pull request that fixes things for the latest version of JSXGraph. Although it has to use an annoying workaround for a JSXGraph issue with their keyboard keydown handler. See jsxgraph/jsxgraph#773. |
drgrice1
force-pushed
the
revert-jsxgraph-upgrade
branch
2 times, most recently
from
6817d3d to
ea784fa
Compare
Something has changed in version 1.11.1 that is messing up the tab order when using the tab key to change focus between points in the graph and such. I will need to update the keyboard handling code in the graphtool to fix this. So for now this reverts back to version 1.10.1 for which the current graphtool code still works. I will try to get this fixed an update back to 1.11.1 before the next release.
drgrice1
force-pushed
the
revert-jsxgraph-upgrade
branch
from
ea784fa to
e348823
Compare
Contributor
|
Closing now that #1357 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something has changed in version 1.11.1 that is messing up the tab order when using the tab key to change focus between points in the graph and such. I will need to update the keyboard handling code in the graphtool to fix this. So for now this reverts back to version 1.10.1 for which the current graphtool code still works.
I will try to get this fixed an update back to 1.11.1 before the next release.