Skip to content

Conversation

@kehach07
Copy link

Checklist

I have read the OpenWISP Contributing Guidelines
.I have manually tested the changes proposed in this pull request.
I have written new test cases for new code and/or updated existing tests for changes to existing code.
I have updated the documentation.

Reference to Existing Issue
Closes #420.

Description of Changes
Improves the initial rendering behavior by adapting the initial zoom level to the graph size.

Small graphs are automatically zoomed in so node labels are visible, while large graphs keep the default zoom to use available screen estate and avoid label clutter. This works consistently with the label visibility logic introduced in #419.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking for a solution to embed in the library with at least 1 automated test, this solutions instead implements the logic in the example, which is not reusable and doesn't add any test, therefore cannot be accepted as is. Feel free to the OpenWISP dev chat to discuss the details of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Use as much screen estate as possible on initial load

2 participants