Skip to content

fix: stop thread pools when an error occurs during startup #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lion7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop thread pools when an error occurs during startup #3107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,18 @@ public synchronized void start() {
public void stop() throws OperatorException {
Duration reconciliationTerminationTimeout =
configurationService.reconciliationTerminationTimeout();

// Always stop the executor service manager to prevent dangling threads,
// even if the operator didn't fully start
configurationService.getExecutorServiceManager().stop(reconciliationTerminationTimeout);

if (!started) {
return;
}
log.info(
"Operator SDK {} is shutting down...", configurationService.getVersion().getSdkVersion());
controllerManager.stop();

configurationService.getExecutorServiceManager().stop(reconciliationTerminationTimeout);
leaderElectionManager.stop();
if (configurationService.closeClientOnStop()) {
getKubernetesClient().close();
Expand Down