Add Lixray account-token sharing and update workspace integration - #277
samuelstroschein wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b2acdc255
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const lix = await getLix(window); | ||
| const result = await lix.execute( | ||
| "SELECT id, content FROM lix_file WHERE path = $1", | ||
| [filePath], | ||
| ); | ||
| if (!result.rows.length) | ||
| throw new Error( |
There was a problem hiding this comment.
When a published file is subsequently deleted locally while its document view remains open, clicking Unpublish file always fails because this existence check runs for both publishing and unpublishing. The DELETE request does not need local content or synchronization verification, so the missing-file check should apply only when publish is true; otherwise users cannot revoke the publication through the advertised Share action without first recreating the file.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in b21a691. Unpublish now bypasses local repository/content access and sync verification; the regression test revokes a deleted file while local storage is unavailable and sync is offline.
|
Found 4 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.svg)
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
flashtype-website | b21a691 | Commit Preview URL Branch Preview URL |
Sep 09 2026, 07:54 PM |
1 participant
Add a Share button for the active file. Users initialize persistent history if needed, create an account API token in Lixray settings, paste it into Flashtype, and confirm private repository sync plus publication of the selected file. The token is validated before storage and encrypted with Electron safeStorage; no desktop OAuth or repository-token compatibility path remains.
The initial upload preserves repository history and uses a durable snapshot for safe retries. Saved connections resume on reopen, bind to the local repository and account, and retain local editing when authentication or sync is unavailable. Publication waits for the chosen file to reach the server. Requires the Lixray gateway/account-token implementation in https://github.com/opral/lixray/pull/356.
Also completes the Lix 0.16 / Atelier integration: use Atelier's editors and review intent, remove unused duplicate editors, expose history context and review actions, add CSV default opening, enforce the 1 GB initialization limit, and recover safely from stalled or crashed repository opens. Updated E2E expectations follow the current Atelier Files and review UI.
Validation: subagent security and integration reviews addressed; 241 unit tests and production build pass. Native Share, CSV opening, recovery, history, workspace windows, and editor fuzz tests pass locally. CI additionally validates the packaged macOS application.