[FSSDK-11512] remove eventManager and segmentManager from odp public api#1048
Merged
[FSSDK-11512] remove eventManager and segmentManager from odp public api#1048
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the external exposure of eventManager and segmentManager from the ODP public API to simplify and consolidate the manager creation process.
- Removed optional segmentManager and eventManager properties from the OdpManagerOptions type
- Updated factory functions and tests to always use default implementations for these managers
- Adjusted exports to use the universal odp manager factory
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/vuid/vuid_manager_factory.browser.ts | Minor cleanup by removing an extraneous blank line |
| lib/odp/odp_manager_factory.universal.ts | Updated to reflect the new API using only requestHandler |
| lib/odp/odp_manager_factory.ts | Removed eventManager/segmentManager options and always uses defaults |
| lib/odp/odp_manager_factory.spec.ts | Removed tests validating custom manager injection |
| lib/odp/odp_manager_factory.react_native.spec.ts | Removed custom manager usage tests |
| lib/odp/odp_manager_factory.node.ts | Removed unused import resulting from removed parameters |
| lib/odp/odp_manager_factory.node.spec.ts | Updated tests to remove custom manager injections |
| lib/odp/odp_manager_factory.browser.spec.ts | Updated tests to remove custom manager injections |
| lib/index.universal.ts | Updated export to use the universal odp manager factory |
| lib/export_types.ts | Added updated type definitions for related odp manager types |
| lib/entrypoint.universal.test-d.ts | Updated type imports to reflect the new odp manager API |
Comments suppressed due to low confidence (2)
lib/odp/odp_manager_factory.ts:47
- Update the type documentation/comments to clearly indicate that segmentManager and eventManager are no longer accepted in OdpManagerOptions.
segmentManager?: OdpSegmentManager;
lib/odp/odp_manager_factory.spec.ts:90
- Remove or update tests related to providing a custom segment manager to ensure that the default manager behavior is fully covered by alternate tests in alignment with the new API design.
it('should use provided segment manager', () => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues