Improved OnLocalhost

[theHenks]

This PR updates the OnLocalhost runmode to allow julia_flags as well as a dir to be parsed. This allows the number of threads as well as the heap-size-hint per local worker to be set independent of the main process, e.g.

rmode = LocalRun(n = 10, julia_flags =Cmd(["--threads=8", "--heap-size-hint=2G"]))

In addition, OnLocalhost was deprecated and renamed to LocalRun.

[oschulz]

Actually, runworkers(OnLocalhost()) reads nicer than runworkers(LocalRun()). Should we rename SlurmRun to OnSLURM and HTCondorRun to OnHTCondor instead?

[theHenks]

Actually, runworkers(OnLocalhost()) reads nicer than runworkers(LocalRun()). Should we rename SlurmRun to OnSLURM and HTCondorRun to OnHTCondor instead?

Fine with me. I would just like to streamline the names. Should I go ahead and change that?

[oschulz]

Should I go ahead and change that?

Yes, let's do it.

[theHenks]

Done. Let's run the tests and merge?

[oschulz]

Running ...

[codecov]

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.45%. Comparing base (893f081) to head (4168800).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/htcondor.jl	0.00%	4 Missing ⚠️
src/slurm.jl	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   67.39%   67.45%   +0.06%     
==========================================
  Files          19       20       +1     
  Lines        1426     1429       +3     
==========================================
+ Hits          961      964       +3     
  Misses        465      465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[theHenks]

I do not understand the error on windows. It somehow fails while checking the nprocs() in test_onworkers.jl

[oschulz]

I'll run it again, maybe just intermittent failure?

[oschulz]

I'll need to find a windows system to check what's wrong here.

[theHenks]

I tried on my windows VM on my mac. The issue is related to the path I am setting in the OnLocahost mode on windows, I had to replace the \\ with / .
Now, all tests run trough at least on my machine