AO3-7140 Changed view of Assignment to be less confusing#5541
AO3-7140 Changed view of Assignment to be less confusing#5541ReverM wants to merge 10 commits intootwcode:masterfrom
Conversation
marcus8448
left a comment
marcus8448
left a comment
There was a problem hiding this comment.
Just a couple wording + translation bits.
Could you add a test for the display of the created_at date for drafts?
| <%= t(".stats.status.unposted") %> | ||
| <% elsif !assignment.fulfilled? %> | ||
| <strong><%= ts("Unapproved") %><!-- BACK END add approve button for mod --></strong> | ||
| <strong><%= t(".stats.status.unfullfilled") %><!-- BACK END add approve button for mod --></strong> |
There was a problem hiding this comment.
| <strong><%= t(".stats.status.unfullfilled") %><!-- BACK END add approve button for mod --></strong> | |
| <strong><%= t(".stats.status.unfulfilled") %><!-- BACK END add approve button for mod --></strong> |
Could also be unapproved to match the displayed text.
(same typo for fulfilled)
| Then I should see "My Assignments" | ||
| And I should not see "Awesome Gift Exchange" | ||
|
|
||
| Scenario: Information regarding the status of an assignment is not confusing (AO3-7140) |
There was a problem hiding this comment.
It's hard to tell what's being tested from the scenario name.
Maybe something like displaying the draft status [and using the creation date] for unposted works? (then the issue number can be omitted as well)
There was a problem hiding this comment.
"Draft Assignments are displayed as draft and use the creation date instead of the published date used for published Assignments"
Is this better?
There was a problem hiding this comment.
How about "Draft Assignments are displayed as draft and use the creation date instead of the publication date"?
config/locales/views/en.yml
Outdated
| fandom: Fandom %{allowed_fandom_count} | ||
| challenge_assignments: | ||
| assignment_blurb: | ||
| header_draft: "%{link} (draft)" |
There was a problem hiding this comment.
Could you change the variable name to title_link or similar?
| <% if !assignment.posted? %> | ||
| <%= t(".header_draft", link: (link_to (assignment.creation.try(:title) || assignment.creation.class.name), assignment.creation, class: "work")) %> | ||
| <% else %> | ||
| <%= t(".header_posted", link: (link_to (assignment.creation.try(:title) || assignment.creation.class.name), assignment.creation, class: "work")) %> |
There was a problem hiding this comment.
The title link can just be inserted directly here (no need for a translation).
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
3 participants
Issue
https://otwarchive.atlassian.net/browse/AO3-7140
Purpose
This changes how the assignment blurb look when you have a drafted work that is unposted (changing Posted to Created and adding (draft) to the title)
Credit
Danaël / Rever ( they / he )
Danaël Villeneuve on Jira