AO3-6690 Choosing an FAQ language and going to Browse Works takes you to the list of works for the FAQ language#5662
Closed
ScottVenkataraman wants to merge 4 commits intootwcode:masterfrom
Closed
Conversation
…rl_options. Update default_locale_only, update_positions, and destroy to pass language_id explicitly. Fix destroy to redirect to the index path instead of the show path after deletion.
…ead of request.query_parameters in require_language_id to avoid OpenRedirectError. Redirect to manage page after update_positions instead of index. Fall back to slug in ArchiveFaq#to_param for newly created records where slug_was is nil
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| redirect_to url_for(request.query_parameters.merge(language_id: @i18n_locale.to_s)) | ||
| end | ||
| redirect_to url_for(params.permit!.merge(language_id: @i18n_locale.to_s)) |
Check warning
Code scanning / Brakeman
Specify exact keys allowed for mass assignment instead of using permit! which allows any keys. Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6690
Purpose
What does this PR do?
When a user logs in, goes to the FAQ page, selects a language for the FAQ page, and then navigates to browse drop down and selects 'works', this PR navigates the user to all works, rather than only works in the language specified in the FAQ page.
Testing Instructions
Follow the steps to reproduce on the jira ticket: https://otwarchive.atlassian.net/browse/AO3-6690
Credit
Scott Venkataraman he/him