Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
external-subnets-ui
branch
from
2b6ca12 to
5ec48fa
Compare
david-crespo
force-pushed
the
subnet-pool-ui
branch
from
27b72e0 to
5b526f8
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
5ec48fa to
85b8cf8
Compare
david-crespo
force-pushed
the
subnet-pool-ui
branch
from
5b526f8 to
3988010
Compare
david-crespo
force-pushed
the
subnet-pool-ui
branch
from
3988010 to
817c209
Compare
Closes #3030 Closes #3031 Operator subnet pools UI is in #3146. <img width="1341" height="875" alt="image" src="https://github.com/user-attachments/assets/4bd0ed83-53f2-4476-99a2-78a28726c9e2" /> <img width="906" height="648" alt="image" src="https://github.com/user-attachments/assets/6b6cf51f-fc57-4e20-94ab-9cfea2f9d91b" /> <img width="506" height="615" alt="image" src="https://github.com/user-attachments/assets/8a5bf4e7-536b-4f69-b35b-6c90a78696e4" />
david-crespo
force-pushed
the
subnet-pool-ui
branch
from
817c209 to
8385806
Compare
david-crespo
force-pushed
the
subnet-pool-ui
branch
from
8385806 to
24ba197
Compare
Saw this while doing #3146, didn't want to add to that diff.
david-crespo
force-pushed
the
subnet-pool-ui
branch
from
24ba197 to
496215a
Compare
|
|
||
| if (pool.name === updatedPool.name) { | ||
| queryClient.invalidateEndpoint('systemSubnetPoolView') | ||
| } |
There was a problem hiding this comment.
Trying to remember why we don’t just always invalidate here.
There was a problem hiding this comment.
Claude with the assist:
console/app/forms/ip-pool-edit.tsx
Lines 52 to 56 in f9286b2
|
|
||
| return { values: Object.keys(errors).length > 0 ? {} : values, errors } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is sort of annoying but it’s the nicest way to validate fields against each other. It’s also extremely testable, as the tests show.
One thing I need to check: I’m pretty sure using a resolver overrides all validation that comes on the fields, like required and stuff like that. If that’s true, we have to make sure the resolver covers everything.
david-crespo
force-pushed
the
subnet-pool-ui
branch
from
3dad050 to
e463d2b
Compare
| body: 'Create an IP pool to see it here', | ||
| buttonText: 'New IP pool', | ||
| buttonTo: pb.ipPoolsNew(), | ||
| } |
There was a problem hiding this comment.
I think this was actually a Claude or Codex discovery — we were using an empty state on the silo IP pools list page that made it sound like you didn't have any IP pools when really there were just none linked to this silo. So here we actually distinguish between the two by looking at whether there are any pools at all. This requires fetching the list of all pools when the page loads, but that's no big deal.
| Are you sure you want to make <HL>{pool.name}</HL> the default{' '} | ||
| {versionLabel} subnet pool for this silo? | ||
| </p> | ||
| ) |
There was a problem hiding this comment.
The truth of this warning relies on this API PR oxidecomputer/omicron#10206 I have in progress that makes subnet pool update demote the current default when setting a new one.
2 participants
Closes #3120
WIP, still need to go through it all. But being able to follow the model of IP pools meant the robot could slam through this.