[dpd-api] migrate to RFD 619 pattern#259
Open
sunshowers wants to merge 4 commits intomainfrom
Open
Conversation
Created using spr 1.3.6-beta.1
25 tasks
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
Apr 19, 2026
Comment on lines
+524
to
+529
| // | ||
| // TODO: `FreeChannels` is unchanged across versions, so this split may be | ||
| // unnecessary — the rationale for gating the endpoint at | ||
| // `VERSION_MCAST_STRICT_UNDERLAY` is not obvious from the code alone. | ||
| // Revisit in a follow-up to either document the reason or collapse back to | ||
| // a single `channels_list` endpoint. |
Contributor
Author
There was a problem hiding this comment.
Wanted to ask about this -- is this correct?
Contributor
There was a problem hiding this comment.
We don't need the split. It was previously introduced because of a misspelling fix in the API doc comment, which shouldn't have warranted a version change (though it's official documentation). Collapsing it back to a single channels_list endpoint is totally the way to go.
Comment on lines
-1562
to
+1512
| versions = VERSION_ATTACHED_SUBNETS.., | ||
| versions = VERSION_ATTACHED_SUBNETS.., |
Contributor
Author
There was a problem hiding this comment.
There were a few tabs which I switched over to spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.