Skip to content

[6/n] make try_compare_flattened obey dry_run #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunshowers wants to merge 1 commit into
base: sunshowers/spr/main.6n-make-try_compare_flattened-obey-dry_run
Choose a base branch
from
Open

[6/n] make try_compare_flattened obey dry_run #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ impl Compare {
},
) => {
// Both old and new are single-element wrappers.
if old_meta != new_meta {
if old_meta != new_meta && !dry_run {
self.push_change(
"schema metadata changed",
old_schema,
Expand Down Expand Up @@ -121,7 +121,7 @@ impl Compare {
//
// A bare ref or inline type does not have metadata, so if the
// old metadata is non-default, report a trivial change.
if has_meaningful_metadata(old_meta) {
if has_meaningful_metadata(old_meta) && !dry_run {
self.push_change(
"schema metadata removed",
old_schema,
Expand Down Expand Up @@ -151,7 +151,7 @@ impl Compare {
//
// A bare ref or inline type does not have metadata, so if the
// new metadata is non-default, report a trivial change.
if has_meaningful_metadata(new_meta) {
if has_meaningful_metadata(new_meta) && !dry_run {
self.push_change(
"schema metadata added",
old_schema,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.